[webkit-changes] [WebKit/WebKit] 88ae5f: [WGSL] Texture read needs unsigned coordinates

Tadeu Zagallo noreply at github.com
Sun Sep 24 22:54:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88ae5ffc56ea933878163867990134c30cb94740
      https://github.com/WebKit/WebKit/commit/88ae5ffc56ea933878163867990134c30cb94740
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-09-24 (Sun, 24 Sep 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl

  Log Message:
  -----------
  [WGSL] Texture read needs unsigned coordinates
https://bugs.webkit.org/show_bug.cgi?id=261885
rdar://115843632

Reviewed by Dan Glastonbury.

We convert textureLoad(texture, coordinate) into texture.read(coordinate), but
the problem is that texture load allows either signed or unsigned values in
the coordinate argument, but metal only allows unsigned values.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/268388@main




More information about the webkit-changes mailing list