[webkit-changes] [WebKit/WebKit] 2f7481: Move off of UIKit SPI: -[UIScrollView _is(Vertical...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f74816e605d1c2539f2613ca928bda62dd21c3c
      https://github.com/WebKit/WebKit/commit/2f74816e605d1c2539f2613ca928bda62dd21c3c
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-09-24 (Sun, 24 Sep 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/UIKitUtilities.h
    M Source/WebKit/UIProcess/ios/UIKitUtilities.mm
    M Source/WebKit/UIProcess/ios/WKScrollView.mm
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
    M Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm
    A Tools/WebKitTestRunner/ios/UIKitSPIForTesting.h

  Log Message:
  -----------
  Move off of UIKit SPI: -[UIScrollView _is(Vertical|Horizontal)Bouncing]
https://bugs.webkit.org/show_bug.cgi?id=262013
rdar://112473874

Reviewed by Aditya Keerthi.

Stop using `-_isVerticalBouncing` and `-_isHorizontalBouncing` on `UIScrollView`; as an alternative,
add a new category helper method, `-[UIScrollView _wk_isScrolledBeyondExtents]`, that returns
whether or not the current content offset is scrolled beyond the minimum or maximum extents of the
scroll view, taking the `-adjustedContentInset` into account.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/UIKitUtilities.h:
* Source/WebKit/UIProcess/ios/UIKitUtilities.mm:
(-[UIScrollView _wk_isScrolledBeyondExtents]):
* Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView _setContentSizePreservingContentOffsetDuringRubberband:]):
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
* Tools/WebKitTestRunner/ios/UIKitSPIForTesting.h: Copied from Source/WebKit/UIProcess/ios/UIKitUtilities.h.

Continue using `-_isVerticalBouncing` and `-_isHorizontalBouncing` in WebKitTestRunner harness logic
to determine when scrolling/zooming animations are complete. We also add an SPI header, specific to
WebKitTestRunner for now, to house these new forward declarations and SPI include points. I'll move
various existing testing-only declarations and includes in UIKitSPI.h into this header in a
subsequent patch.

Canonical link: https://commits.webkit.org/268376@main