[webkit-changes] [WebKit/WebKit] 9c483a: Fix iOS simulator release asan build after 268314 at ...

Alex Christensen noreply at github.com
Sat Sep 23 10:58:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c483aee2979aea8226cdb9080775dc14146dd41
      https://github.com/WebKit/WebKit/commit/9c483aee2979aea8226cdb9080775dc14146dd41
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-09-23 (Sat, 23 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/network/NetworkLoadMetrics.h
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    M Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp

  Log Message:
  -----------
  Fix iOS simulator release asan build after 268314 at main
https://bugs.webkit.org/show_bug.cgi?id=261977
rdar://115910638

Reviewed by Simon Fraser.

Something about my attempt to put RefCounted and vtable overhead in the same
base class wasn't quite the same as having them separate.  This switches to
actually use RefCounted when trying to make a struct that is the same size as
something that is RefCounted for the purposes of verifying that all members
are serialized.

* Source/WebCore/platform/network/NetworkLoadMetrics.h:
* Source/WebKit/Scripts/generate-serializers.py:
(check_type_members.is):
(generate_impl):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(VirtualTableOverhead<true>::~VirtualTableOverhead):
* Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp:
(VirtualTableOverhead<true>::~VirtualTableOverhead):

Canonical link: https://commits.webkit.org/268360@main




More information about the webkit-changes mailing list