[webkit-changes] [WebKit/WebKit] 0a6c03: Rename WTF::Persistence::Coder encode/decode metho...

Brady Eidson noreply at github.com
Sat Sep 23 00:05:38 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a6c03105aa25219198181e1fc052c653e5a4fb5
      https://github.com/WebKit/WebKit/commit/0a6c03105aa25219198181e1fc052c653e5a4fb5
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-09-23 (Sat, 23 Sep 2023)

  Changed paths:
    M Source/WTF/wtf/persistence/PersistentCoders.cpp
    M Source/WTF/wtf/persistence/PersistentCoders.h
    M Source/WTF/wtf/persistence/PersistentDecoder.h
    M Source/WTF/wtf/persistence/PersistentEncoder.h
    M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
    M Source/WebCore/platform/WebCorePersistentCoders.cpp
    M Source/WebCore/platform/WebCorePersistentCoders.h
    M Source/WebCore/platform/network/ResourceResponseBase.cpp
    M Source/WebCore/platform/network/ResourceResponseBase.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.h

  Log Message:
  -----------
  Rename WTF::Persistence::Coder encode/decode methods to set them apart from all other encode/decode methods
https://bugs.webkit.org/show_bug.cgi?id=261990
rdar://115922979

Reviewed by Alex Christensen.

We want to eliminate manually written encode/decode methods used for IPC, and these more explicit method names
for Persistence Coders will help tools more easily find the IPC-specific ones in our code base.

* Source/WTF/wtf/persistence/PersistentCoders.cpp:
(WTF::Persistence::Coder<AtomString>::encodeForPersistence):
(WTF::Persistence::Coder<AtomString>::decodeForPersistence):
(WTF::Persistence::Coder<CString>::encodeForPersistence):
(WTF::Persistence::Coder<CString>::decodeForPersistence):
(WTF::Persistence::Coder<String>::encodeForPersistence):
(WTF::Persistence::Coder<String>::decodeForPersistence):
(WTF::Persistence::Coder<URL>::encodeForPersistence):
(WTF::Persistence::Coder<URL>::decodeForPersistence):
(WTF::Persistence::Coder<SHA1::Digest>::encodeForPersistence):
(WTF::Persistence::Coder<SHA1::Digest>::decodeForPersistence):
(WTF::Persistence::Coder<WallTime>::encodeForPersistence):
(WTF::Persistence::Coder<WallTime>::decodeForPersistence):
(WTF::Persistence::Coder<Seconds>::encodeForPersistence):
(WTF::Persistence::Coder<Seconds>::decodeForPersistence):
(WTF::Persistence::Coder<AtomString>::encode): Deleted.
(WTF::Persistence::Coder<AtomString>::decode): Deleted.
(WTF::Persistence::Coder<CString>::encode): Deleted.
(WTF::Persistence::Coder<CString>::decode): Deleted.
(WTF::Persistence::Coder<String>::encode): Deleted.
(WTF::Persistence::Coder<String>::decode): Deleted.
(WTF::Persistence::Coder<URL>::encode): Deleted.
(WTF::Persistence::Coder<URL>::decode): Deleted.
(WTF::Persistence::Coder<SHA1::Digest>::encode): Deleted.
(WTF::Persistence::Coder<SHA1::Digest>::decode): Deleted.
(WTF::Persistence::Coder<WallTime>::encode): Deleted.
(WTF::Persistence::Coder<WallTime>::decode): Deleted.
(WTF::Persistence::Coder<Seconds>::encode): Deleted.
(WTF::Persistence::Coder<Seconds>::decode): Deleted.
* Source/WTF/wtf/persistence/PersistentCoders.h:
(WTF::Persistence::Coder<std::optional<T>>::encodeForPersistence):
(WTF::Persistence::Coder<std::optional<T>>::decodeForPersistence):
(WTF::Persistence::Coder<std::optional<T>>::encode): Deleted.
(WTF::Persistence::Coder<std::optional<T>>::decode): Deleted.
* Source/WTF/wtf/persistence/PersistentDecoder.h:
(WTF::Persistence::Decoder::operator>>):
* Source/WTF/wtf/persistence/PersistentEncoder.h:
(WTF::Persistence::Encoder::operator<<):
* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::getSerializedCertificate):
* Source/WebCore/platform/WebCorePersistentCoders.cpp:
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData::NodePathComponent>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData::NodePathComponent>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ImportedScriptAttributes>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ImportedScriptAttributes>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ImageResource>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ImageResource>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceRequest>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceRequest>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decodeForPersistence):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::NavigationPreloadState>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::NavigationPreloadState>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::CrossOriginEmbedderPolicy>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::CrossOriginEmbedderPolicy>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ContentSecurityPolicyResponseHeaders>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ContentSecurityPolicyResponseHeaders>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ClientOrigin>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ClientOrigin>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::SecurityOriginData>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::SecurityOriginData>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponse>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponse>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::FetchOptions>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::FetchOptions>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData::NodePathComponent>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData::NodePathComponent>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::AppHighlightRangeData>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ImportedScriptAttributes>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ImportedScriptAttributes>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ImageResource>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ImageResource>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceRequest>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceRequest>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode): Deleted.
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::NavigationPreloadState>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::NavigationPreloadState>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::CrossOriginEmbedderPolicy>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::CrossOriginEmbedderPolicy>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ContentSecurityPolicyResponseHeaders>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ContentSecurityPolicyResponseHeaders>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ClientOrigin>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ClientOrigin>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::SecurityOriginData>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::SecurityOriginData>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceResponse>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceResponse>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::FetchOptions>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::FetchOptions>::decode): Deleted.
(WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::HTTPHeaderMap>::decode): Deleted.
* Source/WebCore/platform/WebCorePersistentCoders.h:
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::encodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::decodeForPersistence):
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::encode): Deleted.
(WTF::Persistence::Coder<WebCore::ResourceResponseBase::CrossThreadData>::decode): Deleted.
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp:
(WTF::Persistence::Coder<WebKit::NetworkCache::Key>::encodeForPersistence):
(WTF::Persistence::Coder<WebKit::NetworkCache::Key>::decodeForPersistence):
(WTF::Persistence::Coder<WebKit::NetworkCache::SubresourceInfo>::encodeForPersistence):
(WTF::Persistence::Coder<WebKit::NetworkCache::SubresourceInfo>::decodeForPersistence):
(WTF::Persistence::Coder<WebKit::NetworkCache::Key>::encode): Deleted.
(WTF::Persistence::Coder<WebKit::NetworkCache::Key>::decode): Deleted.
(WTF::Persistence::Coder<WebKit::NetworkCache::SubresourceInfo>::encode): Deleted.
(WTF::Persistence::Coder<WebKit::NetworkCache::SubresourceInfo>::decode): Deleted.
* Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheKey.h:
(WebKit::NetworkCache::DataKey::encodeForPersistence const):
(WebKit::NetworkCache::DataKey::decodeForPersistence):
(WebKit::NetworkCache::DataKey::encode const): Deleted.
(WebKit::NetworkCache::DataKey::decode): Deleted.

Canonical link: https://commits.webkit.org/268356@main

More information about the webkit-changes mailing list