[webkit-changes] [WebKit/WebKit] 37f52f: Skip animation update and resolution in subtrees d...

Rob Buis noreply at github.com
Fri Sep 22 07:27:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37f52f4720baa187a5eb8454ff878840911e6925
      https://github.com/WebKit/WebKit/commit/37f52f4720baa187a5eb8454ff878840911e6925
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-09-22 (Fri, 22 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/animation-display-lock-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-becomes-visible-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-becomes-visible.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree.html
    M Source/WebCore/animation/DocumentTimelinesController.cpp
    M Source/WebCore/animation/WebAnimation.cpp
    M Source/WebCore/animation/WebAnimation.h
    M Source/WebCore/dom/ContentVisibilityDocumentState.cpp
    M Source/WebCore/dom/ContentVisibilityDocumentState.h
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  Skip animation update and resolution in subtrees depending on content-visibility
https://bugs.webkit.org/show_bug.cgi?id=223930

Reviewed by Tim Nguyen.

This change has two parts:
- skip updating and sending events for animation in hidden content-visibility subtrees
- restart the animation once the subtree becomes visible/unskipped

A test is added for the behaviour of content-visibility: auto and animations, one when using scrollIntoView and
a reftest is included testing animations are restarted once a hidden content-visibility subtree becomes visible.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/animation-display-lock-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-and-scroll.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-becomes-visible-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-becomes-visible.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-animation-in-auto-subtree.html: Added.
* Source/WebCore/animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::isSkippedContentAnimation const):
* Source/WebCore/animation/WebAnimation.h:
* Source/WebCore/dom/ContentVisibilityDocumentState.cpp:
(WebCore::ContentVisibilityDocumentState::checkRelevancyOfContentVisibilityElement const):
(WebCore::ContentVisibilityDocumentState::skippedContentStateDidChange):
* Source/WebCore/dom/ContentVisibilityDocumentState.h:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):

Canonical link: https://commits.webkit.org/268312@main




More information about the webkit-changes mailing list