[webkit-changes] [WebKit/WebKit] 46e648: Use more smart pointers in editing code

Chris Dumez noreply at github.com
Thu Sep 21 17:07:01 PDT 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e64865e4eda18aa70e6e8061ffd78359f57b63
      https://github.com/WebKit/WebKit/commit/46e64865e4eda18aa70e6e8061ffd78359f57b63
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    M Source/WebCore/editing/ApplyBlockElementCommand.cpp
    M Source/WebCore/editing/ApplyBlockElementCommand.h
    M Source/WebCore/editing/ApplyStyleCommand.cpp
    M Source/WebCore/editing/ApplyStyleCommand.h
    M Source/WebCore/editing/BreakBlockquoteCommand.cpp
    M Source/WebCore/editing/BreakBlockquoteCommand.h
    M Source/WebCore/editing/ChangeListTypeCommand.h
    M Source/WebCore/editing/CompositeEditCommand.cpp
    M Source/WebCore/editing/CompositeEditCommand.h
    M Source/WebCore/editing/CreateLinkCommand.cpp
    M Source/WebCore/editing/CreateLinkCommand.h
    M Source/WebCore/editing/DeleteSelectionCommand.cpp
    M Source/WebCore/editing/DeleteSelectionCommand.h
    M Source/WebCore/editing/DictationCommand.cpp
    M Source/WebCore/editing/DictationCommand.h
    M Source/WebCore/editing/EditCommand.cpp
    M Source/WebCore/editing/EditCommand.h
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/Editor.h
    M Source/WebCore/editing/FormatBlockCommand.cpp
    M Source/WebCore/editing/FormatBlockCommand.h
    M Source/WebCore/editing/IndentOutdentCommand.cpp
    M Source/WebCore/editing/IndentOutdentCommand.h
    M Source/WebCore/editing/InsertLineBreakCommand.cpp
    M Source/WebCore/editing/InsertLineBreakCommand.h
    M Source/WebCore/editing/InsertListCommand.cpp
    M Source/WebCore/editing/InsertListCommand.h
    M Source/WebCore/editing/InsertNestedListCommand.h
    M Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
    M Source/WebCore/editing/InsertParagraphSeparatorCommand.h
    M Source/WebCore/editing/InsertTextCommand.cpp
    M Source/WebCore/editing/InsertTextCommand.h
    M Source/WebCore/editing/ModifySelectionListLevel.cpp
    M Source/WebCore/editing/ModifySelectionListLevel.h
    M Source/WebCore/editing/RemoveFormatCommand.cpp
    M Source/WebCore/editing/RemoveFormatCommand.h
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.h
    M Source/WebCore/editing/SimplifyMarkupCommand.cpp
    M Source/WebCore/editing/SimplifyMarkupCommand.h
    M Source/WebCore/editing/SpellingCorrectionCommand.cpp
    M Source/WebCore/editing/TextInsertionBaseCommand.cpp
    M Source/WebCore/editing/TextInsertionBaseCommand.h
    M Source/WebCore/editing/TextIterator.cpp
    M Source/WebCore/editing/TypingCommand.cpp
    M Source/WebCore/editing/TypingCommand.h
    M Source/WebCore/editing/UnlinkCommand.cpp
    M Source/WebCore/editing/UnlinkCommand.h
    M Source/WebCore/editing/VisibleSelection.cpp
    M Source/WebCore/editing/cocoa/EditorCocoa.mm
    M Source/WebCore/editing/gtk/EditorGtk.cpp
    M Source/WebCore/editing/ios/DictationCommandIOS.cpp
    M Source/WebCore/editing/ios/DictationCommandIOS.h
    M Source/WebCore/editing/ios/EditorIOS.mm
    M Source/WebCore/editing/libwpe/EditorLibWPE.cpp
    M Source/WebCore/editing/mac/EditorMac.mm
    M Source/WebCore/editing/win/EditorWin.cpp

  Log Message:
  -----------
  Use more smart pointers in editing code
https://bugs.webkit.org/show_bug.cgi?id=261844

Reviewed by Brent Fulgham.

* Source/WebCore/editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):
* Source/WebCore/editing/ApplyBlockElementCommand.h:
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::ApplyStyleCommand):
* Source/WebCore/editing/ApplyStyleCommand.h:
(WebCore::ApplyStyleCommand::create):
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::BreakBlockquoteCommand):
* Source/WebCore/editing/BreakBlockquoteCommand.h:
(WebCore::BreakBlockquoteCommand::create):
* Source/WebCore/editing/ChangeListTypeCommand.h:
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::CompositeEditCommand):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::ensureComposition):
(WebCore::CompositeEditCommand::applyStyle):
(WebCore::CompositeEditCommand::insertParagraphSeparator):
(WebCore::CompositeEditCommand::insertLineBreak):
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::deleteSelection):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::appendBlockPlaceholder):
(WebCore::CompositeEditCommand::insertBlockPlaceholder):
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::CompositeEditCommand::moveParagraphWithClones):
(WebCore::CompositeEditCommand::moveParagraphs):
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::CreateLinkCommand):
* Source/WebCore/editing/CreateLinkCommand.h:
(WebCore::CreateLinkCommand::create):
* Source/WebCore/editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
(WebCore::DeleteSelectionCommand::removeNode):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
* Source/WebCore/editing/DeleteSelectionCommand.h:
(WebCore::DeleteSelectionCommand::create):
* Source/WebCore/editing/DictationCommand.cpp:
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::insertParagraphSeparator):
* Source/WebCore/editing/DictationCommand.h:
(WebCore::DictationCommand::create):
* Source/WebCore/editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
(WebCore::SimpleEditCommand::SimpleEditCommand):
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::ClearTextCommand::ClearTextCommand):
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::TemporarySelectionChange::TemporarySelectionChange):
(WebCore::Editor::selectionForCommand):
(WebCore::Editor::behavior const):
(WebCore::Editor::client const):
(WebCore::Editor::canEdit const):
(WebCore::Editor::canEditRichly const):
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canCopy const):
(WebCore::Editor::canPaste const):
(WebCore::Editor::canDelete const):
(WebCore::Editor::shouldSmartDelete):
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::deleteSelectionWithSmartDelete):
(WebCore::Editor::clearText):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsPlainTextBypassingDHTML):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::selectedRange):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::shouldInsertText const):
(WebCore::Editor::hasBidiSelection const):
(WebCore::Editor::selectionUnorderedListState const):
(WebCore::Editor::selectionOrderedListState const):
(WebCore::Editor::insertOrderedList):
(WebCore::Editor::insertUnorderedList):
(WebCore::Editor::increaseSelectionListLevel):
(WebCore::Editor::increaseSelectionListLevelOrdered):
(WebCore::Editor::increaseSelectionListLevelUnordered):
(WebCore::Editor::decreaseSelectionListLevel):
(WebCore::Editor::removeFormattingAndStyle):
(WebCore::Editor::findEventTargetFromSelection const):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::selectionStartHasStyle const):
(WebCore::Editor::selectionHasStyle const):
(WebCore::Editor::selectionStartCSSPropertyValue):
(WebCore::Editor::indent):
(WebCore::Editor::outdent):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::clear):
(WebCore::Editor::insertText):
(WebCore::Editor::insertTextForConfirmedComposition):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore::Editor::canCopyFont const):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::paste):
(WebCore::Editor::pasteAsQuotation):
(WebCore::Editor::quoteFragmentForPasting):
(WebCore::Editor::changeSelectionListType):
(WebCore::Editor::simplifyMarkup):
(WebCore::Editor::copyURL):
(WebCore::Editor::copyImage):
(WebCore::Editor::revealSelectionIfNeededAfterLoadingImageForElement):
(WebCore::Editor::renderLayerDidScroll):
(WebCore::Editor::registerCustomUndoStep):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::baseWritingDirectionForSelectionStart const):
(WebCore::Editor::selectComposition):
(WebCore::Editor::confirmOrCancelCompositionAndNotifyClient):
(WebCore::SetCompositionScope::SetCompositionScope):
(WebCore::Editor::setComposition):
(WebCore::Editor::ignoreSpelling):
(WebCore::Editor::learnSpelling):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::misspelledWordAtCaretOrRange const):
(WebCore::Editor::guessesForMisspelledWord const):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::isSpellCheckingEnabledInFocusedNode const):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::setIgnoreSelectionChanges):
(WebCore::Editor::getCompositionSelection const):
(WebCore::Editor::transpose):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::selectedText const):
(WebCore::Editor::selectedTextForDataTransfer const):
(WebCore::Editor::insertTextPlaceholder):
(WebCore::Editor::removeTextPlaceholder):
(WebCore::Editor::shouldChangeSelection const):
(WebCore::Editor::computeAndSetTypingStyle):
(WebCore::Editor::findString):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::shouldDetectTelephoneNumbers const):
(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::editorUIUpdateTimerFired):
(WebCore::Editor::selectionStartHasMarkerFor const):
(WebCore::Editor::stringForCandidateRequest const):
(WebCore::Editor::contextRangeForCandidateRequest const):
(WebCore::Editor::fontAttributesAtSelectionStart):
(WebCore::Editor::notifyClientOfAttachmentUpdates):
(WebCore::Editor::insertAttachment):
(WebCore::Editor::handleAcceptedCandidate):
(WebCore::Editor::unifiedTextCheckerEnabled const):
(WebCore::Editor::toggleOverwriteModeEnabled):
(WebCore::Editor::styleForSelectionStart):
(WebCore::Editor::fontForSelection):
(WebCore::Editor::canCopyExcludingStandaloneImages const):
* Source/WebCore/editing/Editor.h:
(WebCore::Editor::protectedCompositionNode const):
(WebCore::Editor::document const):
(WebCore::Editor::protectedDocument const):
* Source/WebCore/editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::FormatBlockCommand):
* Source/WebCore/editing/FormatBlockCommand.h:
(WebCore::FormatBlockCommand::create):
* Source/WebCore/editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::IndentOutdentCommand):
(WebCore::IndentOutdentCommand::outdentParagraph):
* Source/WebCore/editing/IndentOutdentCommand.h:
(WebCore::IndentOutdentCommand::create):
* Source/WebCore/editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::InsertLineBreakCommand):
(WebCore::InsertLineBreakCommand::doApply):
* Source/WebCore/editing/InsertLineBreakCommand.h:
(WebCore::InsertLineBreakCommand::create):
* Source/WebCore/editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::insertList):
(WebCore::InsertListCommand::InsertListCommand):
* Source/WebCore/editing/InsertListCommand.h:
* Source/WebCore/editing/InsertNestedListCommand.h:
* Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
* Source/WebCore/editing/InsertParagraphSeparatorCommand.h:
(WebCore::InsertParagraphSeparatorCommand::create):
* Source/WebCore/editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand):
* Source/WebCore/editing/InsertTextCommand.h:
(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
* Source/WebCore/editing/ModifySelectionListLevel.cpp:
(WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
(WebCore::DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand):
* Source/WebCore/editing/ModifySelectionListLevel.h:
(WebCore::DecreaseSelectionListLevelCommand::create):
* Source/WebCore/editing/RemoveFormatCommand.cpp:
(WebCore::RemoveFormatCommand::RemoveFormatCommand):
* Source/WebCore/editing/RemoveFormatCommand.h:
(WebCore::RemoveFormatCommand::create):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
* Source/WebCore/editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::create):
* Source/WebCore/editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::SimplifyMarkupCommand):
* Source/WebCore/editing/SimplifyMarkupCommand.h:
(WebCore::SimplifyMarkupCommand::create):
* Source/WebCore/editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionRecordUndoCommand::create):
(WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand):
* Source/WebCore/editing/TextInsertionBaseCommand.cpp:
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
* Source/WebCore/editing/TextInsertionBaseCommand.h:
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::TextIterator::advance):
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextRun):
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
* Source/WebCore/editing/TypingCommand.h:
* Source/WebCore/editing/UnlinkCommand.cpp:
(WebCore::UnlinkCommand::UnlinkCommand):
* Source/WebCore/editing/UnlinkCommand.h:
(WebCore::UnlinkCommand::create):
* Source/WebCore/editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
* Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::selectionInHTMLFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeSelection):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::replaceSelectionWithAttributedString):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::takeFindStringFromSelection):
(WebCore::Editor::readSelectionFromPasteboard):
(WebCore::Editor::replaceNodeFromPasteboard):
* Source/WebCore/editing/ios/DictationCommandIOS.cpp:
(WebCore::DictationCommandIOS::DictationCommandIOS):
(WebCore::DictationCommandIOS::create):
* Source/WebCore/editing/ios/DictationCommandIOS.h:
* Source/WebCore/editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
* Source/WebCore/editing/mac/EditorMac.mm:
(WebCore::Editor::platformCopyFont):
(WebCore::Editor::platformPasteFont):
(WebCore::Editor::selectionWillChange):

Canonical link: https://commits.webkit.org/268286@main

More information about the webkit-changes mailing list