[webkit-changes] [WebKit/WebKit] 39763b: [Filters] Filters with outsets have to repaint all...

Said Abou-Hallawa noreply at github.com
Thu Sep 21 16:26:34 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39763b0eba704c47027dffc65c907386376c8590
      https://github.com/WebKit/WebKit/commit/39763b0eba704c47027dffc65c907386376c8590
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    A LayoutTests/css3/filters/drop-shadow-target-clipped-expected.html
    A LayoutTests/css3/filters/drop-shadow-target-clipped.html
    M Source/WebCore/rendering/RenderLayerFilters.cpp
    M Source/WebCore/rendering/RenderLayerFilters.h

  Log Message:
  -----------
  [Filters] Filters with outsets have to repaint all the filterRegion if GraphicsStyles are used
https://bugs.webkit.org/show_bug.cgi?id=261856
rdar://115817290

Reviewed by Simon Fraser.

The bounding box of a target element might all be clipped. But a filter effect,
like drop shadow, may still be visible in the current viewport. If GraphicsStyles
are used, we need to redraw the whole filterRegion.

* LayoutTests/css3/filters/drop-shadow-target-clipped-expected.html: Added.
* LayoutTests/css3/filters/drop-shadow-target-clipped.html: Added.
* Source/WebCore/rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::needsRedrawSourceImage const):
(WebCore::RenderLayerFilters::beginFilterEffect):
* Source/WebCore/rendering/RenderLayerFilters.h:

Canonical link: https://commits.webkit.org/268282@main




More information about the webkit-changes mailing list