[webkit-changes] [WebKit/WebKit] 3fc18d: AX: AXWebSessionID, AXIsMultiline, AXReadOnlyValue...

Tyler Wilcock noreply at github.com
Thu Sep 21 09:32:44 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fc18de4dfcd6cff22179de72aa5f75a248f90fe
      https://github.com/WebKit/WebKit/commit/3fc18de4dfcd6cff22179de72aa5f75a248f90fe
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-09-21 (Thu, 21 Sep 2023)

  Changed paths:
    R LayoutTests/accessibility/document-attributes-expected.txt
    R LayoutTests/accessibility/document-attributes.html
    M LayoutTests/accessibility/mac/document-attributes-expected.txt
    R LayoutTests/accessibility/mac/session-id-expected.txt
    R LayoutTests/accessibility/mac/session-id.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
    M Tools/DumpRenderTree/AccessibilityUIElement.cpp
    M Tools/DumpRenderTree/AccessibilityUIElement.h
    M Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
    M Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl
    M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
    M Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
    M Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm
    M Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp

  Log Message:
  -----------
  AX: AXWebSessionID, AXIsMultiline, AXReadOnlyValue, AXDocumentURIAttribute, and AXDocumentEncodingAttribute are unused by AX clients
https://bugs.webkit.org/show_bug.cgi?id=261799
rdar://problem/115764193

Reviewed by Chris Fleizach and Andres Gonzalez.

This patch removes the tests and code supporting these attributes.

* LayoutTests/accessibility/document-attributes-expected.txt: Removed.
* LayoutTests/accessibility/document-attributes.html: Removed.
* LayoutTests/accessibility/mac/document-attributes-expected.txt:
* LayoutTests/accessibility/mac/session-id-expected.txt: Removed.
* LayoutTests/accessibility/mac/session-id.html: Removed.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::documentURI const): Deleted.
(WebCore::AccessibilityObject::documentEncoding const): Deleted.
(WebCore::AccessibilityObject::sessionID const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
(WebCore::AXCoreObject::ariaIsMultiline const):
(WebCore::AXCoreObject::readOnlyValue const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::sessionID const): Deleted.
(WebCore::AXIsolatedObject::documentURI const): Deleted.
(WebCore::AXIsolatedObject::documentEncoding const): Deleted.
(WebCore::AXIsolatedObject::sessionIDAttributeValue const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/268256@main




More information about the webkit-changes mailing list