[webkit-changes] [WebKit/WebKit] 4667cd: Have AsyncAudioDecoder use NativePromise

Jean-Yves Avenard noreply at github.com
Wed Sep 20 23:32:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4667cdc966a45d336d34283e302d1e1a77a2420a
      https://github.com/WebKit/WebKit/commit/4667cdc966a45d336d34283e302d1e1a77a2420a
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp
    M Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h
    M Source/WebCore/Modules/webaudio/BaseAudioContext.cpp

  Log Message:
  -----------
  Have AsyncAudioDecoder use NativePromise
https://bugs.webkit.org/show_bug.cgi?id=261601
rdar://115549443

Reviewed by Youenn Fablet.

The purpose of this change is mostly to show how some threading work can
be greatly simplified with the new NativePromise object.

No change in observable behaviour.

* Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder): Deleted.
(WebCore::AsyncAudioDecoder::runLoop): Deleted.
(WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask): Deleted.
(WebCore::AsyncAudioDecoder::DecodingTask::decode): Deleted.
(WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete): Deleted.
* Source/WebCore/Modules/webaudio/AsyncAudioDecoder.h:
* Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:
(WebCore::BaseAudioContext::decodeAudioData):

Canonical link: https://commits.webkit.org/268236@main




More information about the webkit-changes mailing list