[webkit-changes] [WebKit/WebKit] d4d733: [ Ventura+ wk1 ] editing/spelling/retro-correction...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d4d733cacadd7dad7ebbb0ab405c4c463372531c
      https://github.com/WebKit/WebKit/commit/d4d733cacadd7dad7ebbb0ab405c4c463372531c
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M LayoutTests/editing/spelling/retro-correction-spelling-markers.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/resources/ui-helper.js
    M Tools/DumpRenderTree/TestRunner.cpp

  Log Message:
  -----------
  [ Ventura+ wk1 ] editing/spelling/retro-correction-spelling-markers.html is a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=261495
rdar://115411037

Reviewed by Aditya Keerthi and Abrar Rahman Protyasha.

Make this test more robust against underlying changes to spell checking on macOS, by ensuring
consistent text checking results via `LayoutTestSpellChecker`.

* LayoutTests/editing/spelling/retro-correction-spelling-markers.html:
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/resources/ui-helper.js:

Ensure that this helper function doesn't trigger a crash on non-Cocoa ports by bailing gracefully in
the case where we're neither macOS nor iOS.

(window.UIHelper.async setSpellCheckerResults):
* Tools/DumpRenderTree/TestRunner.cpp:
(isMacCallback):
(TestRunner::staticFunctions):

Implement `TestRunner.isMac` so that the above check in `ui-helper.js` works as intended.

Canonical link: https://commits.webkit.org/268222@main