[webkit-changes] [WebKit/WebKit] fd3a4d: Optionally return a StreamConnectionPair in Stream...

Don Olmstead noreply at github.com
Wed Sep 20 15:59:00 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd3a4d231104825ad39d97741e09928f391c32bb
      https://github.com/WebKit/WebKit/commit/fd3a4d231104825ad39d97741e09928f391c32bb
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/StreamClientConnection.cpp
    M Source/WebKit/Platform/IPC/StreamClientConnection.h
    M Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp

  Log Message:
  -----------
  Optionally return a StreamConnectionPair in StreamClientConnection::create
https://bugs.webkit.org/show_bug.cgi?id=261782

Reviewed by Kimmo Kinnunen.

Change function signature of `StreamClientConnection::create` to return
a `std::optional<StreamConnectionPair>`. Modify `StreamConnectionPair`
to use a `Ref<StreamClientConnection>` since the value will never be
`null`. Updated the call sites for `StreamClientConnection::create` to
handle the changes.

This is a step towards `SharedMemory::Handle` also always being valid.

* Source/WebKit/Platform/IPC/StreamClientConnection.cpp:
(IPC::StreamClientConnection::create):
* Source/WebKit/Platform/IPC/StreamClientConnection.h:
* Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::create):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::ensureGPUProcessConnection):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::create):
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::createError):
(WebKit::IPCTestingAPI::JSIPC::createStreamClientConnection):
* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:

Canonical link: https://commits.webkit.org/268220@main




More information about the webkit-changes mailing list