[webkit-changes] [WebKit/WebKit] daaaec: [Wasm-GC] Remove toJSValue calls for struct operat...
Asumu Takikawa
noreply at github.com
Wed Sep 20 11:13:32 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: daaaece7a06e0000b42fd7c8ee873c908b5e344f
https://github.com/WebKit/WebKit/commit/daaaece7a06e0000b42fd7c8ee873c908b5e344f
Author: Asumu Takikawa <asumu at igalia.com>
Date: 2023-09-20 (Wed, 20 Sep 2023)
Changed paths:
M Source/JavaScriptCore/wasm/WasmOperations.cpp
M Source/JavaScriptCore/wasm/WasmOperationsInlines.h
M Source/JavaScriptCore/wasm/WasmSlowPaths.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h
M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h
Log Message:
-----------
[Wasm-GC] Remove toJSValue calls for struct operations
https://bugs.webkit.org/show_bug.cgi?id=260910
Reviewed by Justin Michaud.
This patch adjusts the JSWebAssemblyStruct::set() method so that it
takes an EncodedJSValue instead of a JSValue. This saves unnecessary
conversions between representations and eliminates potential exception
throws.
In the future the original functionality may be helpful for expanded JS
API capabilities.
This patch also makes a minor adjustment to JSWebAssemblyArray::set() to
match the struct version.
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/wasm/WasmOperationsInlines.h:
(JSC::Wasm::arraySet):
(JSC::Wasm::structNew):
(JSC::Wasm::structSet):
* Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h:
* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.cpp:
(JSC::JSWebAssemblyStruct::set):
* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h:
Canonical link: https://commits.webkit.org/268211@main
More information about the webkit-changes
mailing list