[webkit-changes] [WebKit/WebKit] 17ed49: AutoInstaller should name directory based on ABI
Sam Sneddon
noreply at github.com
Wed Sep 20 09:55:32 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 17ed495179235a185b77e1ef4d02778d9fb1dda0
https://github.com/WebKit/WebKit/commit/17ed495179235a185b77e1ef4d02778d9fb1dda0
Author: Sam Sneddon <gsnedders at apple.com>
Date: 2023-09-20 (Wed, 20 Sep 2023)
Changed paths:
M Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py
M Tools/Scripts/libraries/resultsdbpy/container
M Tools/Scripts/libraries/resultsdbpy/run
M Tools/Scripts/libraries/resultsdbpy/run-tests
M Tools/Scripts/libraries/webkitbugspy/run-tests
M Tools/Scripts/libraries/webkitcorepy/run-tests
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M Tools/Scripts/libraries/webkitscmpy/run-tests
M Tools/Scripts/webkitpy/__init__.py
Log Message:
-----------
AutoInstaller should name directory based on ABI
https://bugs.webkit.org/show_bug.cgi?id=224669
Reviewed by Jonathan Bedard.
While the autoinstaller currently (mostly!) puts autoinstalled libraries
into a directory such as `python-3-arm64`, this doesn't suffice to
uniquely identify the ABI of the interpreter.
In practice, this mostly works because since Python 3.2 distutils will
compile extensions into files with suffixes such as
`cpython-39-darwin.so`, and most extension modules we compile are
optional "speedup" modules where failing to have an appropriate
extension module will simply degrade performance but not prevent
operation.
This replaces our current tags with a string that should match
`str(list(packaging.tags.sys_tags())[0])`.
It doesn't, however, use packaging directly, because we can't install
packaging until we know what directory we're using. If we do in future
move to vendoring packaging we should be able to migrate to this without
invalidating everyone's local autoinstall directories.
* Tools/Scripts/libraries/reporelaypy/reporelaypy/webserver.py:
* Tools/Scripts/libraries/resultsdbpy/container:
* Tools/Scripts/libraries/resultsdbpy/run:
* Tools/Scripts/libraries/resultsdbpy/run-tests:
* Tools/Scripts/libraries/webkitbugspy/run-tests:
* Tools/Scripts/libraries/webkitcorepy/run-tests:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall._platform_compatibility_tag):
(AutoInstall):
(AutoInstall.set_directory):
* Tools/Scripts/libraries/webkitscmpy/run-tests:
* Tools/Scripts/webkitpy/__init__.py:
Canonical link: https://commits.webkit.org/268205@main
More information about the webkit-changes
mailing list