[webkit-changes] [WebKit/WebKit] 9cb0f2: [WebGPU] https://webgpu.github.io/webgpu-samples/s...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9cb0f24c1250164563771ba123730f0be8d1e42d
      https://github.com/WebKit/WebKit/commit/9cb0f24c1250164563771ba123730f0be8d1e42d
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] https://webgpu.github.io/webgpu-samples/samples/samplerParameters does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=260233
<radar://113939360>

Reviewed by Tadeu Zagallo.

Get another github sample working.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
entry.binding should always be the index.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::addDescriptor):
arguments.count is not the correct value, pass it instead.

(WebGPU::Device::createBindGroupLayout):
The array of MTLArgumentDescriptor instances must be sorted by index
otherwise the validation layer fails and it doesn't appear to work
either.

(WebGPU::BindGroupLayout::bindingAccessForBindingIndex const):
(WebGPU::BindGroupLayout::indexForBinding const): Deleted.
No longer returns a pair, just a single optional.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::addPipelineLayouts):
Fix off by one error.

Canonical link: https://commits.webkit.org/268200@main