[webkit-changes] [WebKit/WebKit] d16519: DisplayListDrawingEnabled should not affect HTMLVi...

Kimmo Kinnunen noreply at github.com
Wed Sep 20 03:12:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d165194c7ef8f74923dfa1cb612da1f5a94c86b3
      https://github.com/WebKit/WebKit/commit/d165194c7ef8f74923dfa1cb612da1f5a94c86b3
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebCore/html/HTMLVideoElement.cpp

  Log Message:
  -----------
  DisplayListDrawingEnabled should not affect HTMLVideoElement intermediate buffers
https://bugs.webkit.org/show_bug.cgi?id=261407
rdar://115284270

Reviewed by Antti Koivisto.

DisplayListDrawingEnabled is about recording the drawing commands done
to render RenderLayerBacking. Even if the HTMLVideoElement
intermediate buffers are toggled to be display lists, this does not
affect anything.

Remove the use of DisplayListDrawingEnabled setting and just construct
default ImageBuffer buffers.

If later on the video element intermediate buffer contents need to
appear in RenderLayerBacking lists, the intermediate buffers should be
real display lists or the contents should be drawn to the
RenderLayerBacking GraphicsContext.

HTMLVideoElement::createBufferForPainting() is used for ImageBitmap
creation, and this does not benefit from the display lists at all.

* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createBufferForPainting const):

Canonical link: https://commits.webkit.org/268190@main




More information about the webkit-changes mailing list