[webkit-changes] [WebKit/WebKit] 0e4fcb: MediaControlTextTrackContainerElement uses Image r...
Kimmo Kinnunen
noreply at github.com
Wed Sep 20 01:39:27 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0e4fcb51c7983b701cf7a9aaadb1b34cd52d2cd2
https://github.com/WebKit/WebKit/commit/0e4fcb51c7983b701cf7a9aaadb1b34cd52d2cd2
Author: Kimmo Kinnunen <kkinnunen at apple.com>
Date: 2023-09-20 (Wed, 20 Sep 2023)
Changed paths:
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp
M Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h
M Source/WebCore/platform/graphics/TextTrackRepresentation.h
M Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm
M Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm
Log Message:
-----------
MediaControlTextTrackContainerElement uses Image redundantly, should use NativeImage
https://bugs.webkit.org/show_bug.cgi?id=261723
rdar://problem/115709836
Reviewed by Said Abou-Hallawa.
WebCore::Image is mostly about DOM images.
Callers of MediaControlTextTrackContainerElement::createTextTrackRepresentationImage()
use the platform image, e.g. WebCore::NativeImage. Return this type.
Work towards removing ImageBuffer::sinkIntoImage().
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
* Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.h:
* Source/WebCore/platform/graphics/TextTrackRepresentation.h:
* Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
(WebCore::TextTrackRepresentationCocoa::update):
* Source/WebKit/WebProcess/cocoa/TextTrackRepresentationCocoa.mm:
(WebKit::WebTextTrackRepresentationCocoa::update):
Canonical link: https://commits.webkit.org/268188@main
More information about the webkit-changes
mailing list