[webkit-changes] [WebKit/WebKit] 4202a8: Drawing patterns use Image redundantly when cachin...

Kimmo Kinnunen noreply at github.com
Wed Sep 20 00:46:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4202a8a96888091029f0538738502352b878041b
      https://github.com/WebKit/WebKit/commit/4202a8a96888091029f0538738502352b878041b
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/BitmapImage.cpp
    M Source/WebCore/platform/graphics/BitmapImage.h
    M Source/WebCore/platform/graphics/GradientImage.cpp
    M Source/WebCore/platform/graphics/GradientImage.h
    M Source/WebCore/svg/graphics/SVGImage.cpp

  Log Message:
  -----------
  Drawing patterns use Image redundantly when caching patterns, should use NativeImage instead
https://bugs.webkit.org/show_bug.cgi?id=261724
rdar://115710643

Reviewed by Said Abou-Hallawa.

WebCore::Image is mostly about DOM images.

The various caches related to drawing patterns convert ImageBuffers
to Images, while they really need NativeImages. Use NativeImages
instead.

Work towards removing GraphicsContext::sinkIntoImage().

* Source/WebCore/platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
* Source/WebCore/platform/graphics/BitmapImage.h:
* Source/WebCore/platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
* Source/WebCore/platform/graphics/GradientImage.h:
* Source/WebCore/svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):

Canonical link: https://commits.webkit.org/268185@main




More information about the webkit-changes mailing list