[webkit-changes] [WebKit/WebKit] 7f9259: Regression(267850 at main) Flaky crash under Permissi...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f9259f2cf69171ea980ee8e98e1e101de63e8ec
      https://github.com/WebKit/WebKit/commit/7f9259f2cf69171ea980ee8e98e1e101de63e8ec
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M Source/WebCore/Modules/permissions/PermissionStatus.cpp

  Log Message:
  -----------
  Regression(267850 at main) Flaky crash under PermissionStatus::virtualHasPendingActivity()
https://bugs.webkit.org/show_bug.cgi?id=261763

Reviewed by Brent Fulgham.

PermissionStatus::virtualHasPendingActivity() can get called on a GC-thread,
in which case we would try to ref the Document off the main thread, thus
hitting an assertion in Node::ref().

Switch to WeakPtr to avoid the issue.

* Source/WebCore/Modules/permissions/PermissionStatus.cpp:
(WebCore::PermissionStatus::virtualHasPendingActivity const):

Canonical link: https://commits.webkit.org/268145@main