[webkit-changes] [WebKit/WebKit] e8f87c: [IFC][Ruby] Only inline axis layout needs InlineItems
Alan Baradlay
noreply at github.com
Tue Sep 19 11:38:50 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e8f87cf56facfafc6e88f016d4b84de6b2e42437
https://github.com/WebKit/WebKit/commit/e8f87cf56facfafc6e88f016d4b84de6b2e42437
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-09-19 (Tue, 19 Sep 2023)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h
M Source/WebCore/layout/layouttree/LayoutBox.h
Log Message:
-----------
[IFC][Ruby] Only inline axis layout needs InlineItems
https://bugs.webkit.org/show_bug.cgi?id=261745
Reviewed by Antti Koivisto.
This is in preparation for running block axis layout for ruby content (height/annotation box placement) which happens
after line breaking where we don't have InlineItems anymore.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::handleRubyContent):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: Move InlineItems out of c'tor.
(WebCore::Layout::RubyFormattingContext::RubyFormattingContext):
(WebCore::Layout::RubyFormattingContext::layoutInlineAxis):
(WebCore::Layout::RubyFormattingContext::layoutRubyBaseInlineAxis):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:
* Source/WebCore/layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isRubyBase const):
Canonical link: https://commits.webkit.org/268138@main
More information about the webkit-changes
mailing list