[webkit-changes] [WebKit/WebKit] 1bb596: PointerEventsHitRules::EHitTesting should be an en...

Abrar Rahman Protyasha noreply at github.com
Tue Sep 19 11:31:03 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bb596a765e46950f0988b88db1277b37dfc7d37
      https://github.com/WebKit/WebKit/commit/1bb596a765e46950f0988b88db1277b37dfc7d37
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M Source/WebCore/rendering/PointerEventsHitRules.cpp
    M Source/WebCore/rendering/PointerEventsHitRules.h
    M Source/WebCore/rendering/svg/RenderSVGImage.cpp
    M Source/WebCore/rendering/svg/RenderSVGShape.cpp
    M Source/WebCore/rendering/svg/RenderSVGText.cpp
    M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp

  Log Message:
  -----------
  PointerEventsHitRules::EHitTesting should be an enum class
https://bugs.webkit.org/show_bug.cgi?id=261728
rdar://115715202

Reviewed by Aditya Keerthi.

This commit narrows down the underlying type of EHitTesting, converts it
to an enum class for type safety, and renames it to HitTestingTargetType
to better reflect the enumeration's meaning.

* Source/WebCore/rendering/PointerEventsHitRules.cpp:
(WebCore::PointerEventsHitRules::PointerEventsHitRules):
* Source/WebCore/rendering/PointerEventsHitRules.h:
(): Deleted.
* Source/WebCore/rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtPoint):
* Source/WebCore/rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtPoint):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):
* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp:
(WebCore::LegacyRenderSVGImage::nodeAtFloatPoint):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp:
(WebCore::LegacyRenderSVGShape::nodeAtFloatPoint):

Canonical link: https://commits.webkit.org/268136@main




More information about the webkit-changes mailing list