[webkit-changes] [WebKit/WebKit] b21e19: [iOS] Stop using `-[UIPopoverPresentationControlle...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b21e19bbf7995da57b77823019869c718eb65d15
      https://github.com/WebKit/WebKit/commit/b21e19bbf7995da57b77823019869c718eb65d15
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm

  Log Message:
  -----------
  [iOS] Stop using `-[UIPopoverPresentationController _setCentersPopoverIfSourceViewNotSet:]`
https://bugs.webkit.org/show_bug.cgi?id=261747

Reviewed by Aditya Keerthi.

Replace the single use of `-_setCentersPopoverIfSourceViewNotSet:` in Web Share code (in the case
where no target rect is explicitly specified) with equivalent logic to present the popover with:

1. The `WKWebView` as the source view.
2. The target rect being the entire bounds of the web view.
3. No permitted arrow direction (which causes the popover to show up with no arrow).

This achieves the same final effect as setting the SPI flag to `YES`.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:
(-[WKShareSheet presentWithShareDataArray:inRect:]):

Canonical link: https://commits.webkit.org/268133@main