[webkit-changes] [WebKit/WebKit] 64acc6: Introduce PushSubscriptionOwner

Brady Eidson noreply at github.com
Tue Sep 19 09:01:59 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64acc68e8da636201e7a01af80aaae82bfd60b07
      https://github.com/WebKit/WebKit/commit/64acc68e8da636201e7a01af80aaae82bfd60b07
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M Source/WebCore/Modules/push-api/PushManager.cpp
    M Source/WebCore/Modules/push-api/PushManager.h
    M Source/WebCore/Modules/push-api/PushSubscription.cpp
    M Source/WebCore/Modules/push-api/PushSubscription.h
    A Source/WebCore/Modules/push-api/PushSubscriptionOwner.h
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/workers/service/ServiceWorkerRegistration.h

  Log Message:
  -----------
  Introduce PushSubscriptionOwner
https://bugs.webkit.org/show_bug.cgi?id=261711
rdar://115690541

Reviewed by Megan Gardner and Andy Estes.

To support Declarative Web Push, a few push-related areas that currently refer to ServiceWorkerRegistration
will need to refer to a more abstract "PushSubscriptionOwner" instead.

Introduce that concept here in a standalone patch before starting to pile on to it.

* Source/WebCore/Modules/push-api/PushManager.cpp:
(WebCore::PushManager::PushManager):
(WebCore::PushManager::ref const):
(WebCore::PushManager::deref const):
(WebCore::PushManager::subscribe):
(WebCore::PushManager::getSubscription):
* Source/WebCore/Modules/push-api/PushManager.h:
* Source/WebCore/Modules/push-api/PushSubscription.cpp:
(WebCore::PushSubscription::PushSubscription):
(WebCore::PushSubscription::unsubscribe):
* Source/WebCore/Modules/push-api/PushSubscription.h:
* Source/WebCore/Modules/push-api/PushSubscriptionOwner.h: Copied from Source/WebCore/Modules/push-api/PushManager.h.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/workers/service/ServiceWorkerRegistration.h:

Canonical link: https://commits.webkit.org/268129@main




More information about the webkit-changes mailing list