[webkit-changes] [WebKit/WebKit] 0a0349: [WGSL] Global variable rewriter is wrong for overr...
Tadeu Zagallo
noreply at github.com
Tue Sep 19 02:17:14 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0a03496ec0c117284b068bf28354403a6759774c
https://github.com/WebKit/WebKit/commit/0a03496ec0c117284b068bf28354403a6759774c
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-09-19 (Tue, 19 Sep 2023)
Changed paths:
M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
Log Message:
-----------
[WGSL] Global variable rewriter is wrong for overrides
https://bugs.webkit.org/show_bug.cgi?id=261677
rdar://115655426
Reviewed by Dan Glastonbury.
When determining which global variables were used, the rewriter should skip the
path that deals with resources when visiting overrides, as they aren't resources.
The fix is trivial, I originally wrote a `break` where it should be `continue`
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::determineUsedGlobals):
Canonical link: https://commits.webkit.org/268115@main
More information about the webkit-changes
mailing list