[webkit-changes] [WebKit/WebKit] ab192b: Rename HighlightData to RenderHighlight and Select...

megangardner noreply at github.com
Mon Sep 18 12:13:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab192be42c5ef4cf2771f3ade70eba6a4caab3bc
      https://github.com/WebKit/WebKit/commit/ab192be42c5ef4cf2771f3ade70eba6a4caab3bc
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/DragImage.cpp
    R Source/WebCore/rendering/HighlightData.cpp
    R Source/WebCore/rendering/HighlightData.h
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/MarkedText.cpp
    A Source/WebCore/rendering/RenderHighlight.cpp
    A Source/WebCore/rendering/RenderHighlight.h
    M Source/WebCore/rendering/RenderObject.h
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderReplaced.h
    A Source/WebCore/rendering/RenderSelection.cpp
    A Source/WebCore/rendering/RenderSelection.h
    M Source/WebCore/rendering/RenderView.h
    R Source/WebCore/rendering/SelectionRangeData.cpp
    R Source/WebCore/rendering/SelectionRangeData.h

  Log Message:
  -----------
  Rename HighlightData to RenderHighlight and SelectionRangeData to RenderSelection as part of rename work to clarify classes around highlights.
https://bugs.webkit.org/show_bug.cgi?id=261634
rdar://115589022

Reviewed by Richard Robinson.

Several classes associated with Highlights have a very confusing naming
structure. This is the third rename of several to help clarify
what these classes are and their relationship to each other.

* Source/WebCore/rendering/RenderHighlight.cpp: Renamed from Source/WebCore/rendering/HighlightData.cpp.
(WebCore::RenderRangeIterator::RenderRangeIterator):
(WebCore::RenderRangeIterator::current const):
(WebCore::RenderRangeIterator::next):
(WebCore::RenderRangeIterator::checkForSpanner):
(WebCore::rendererAfterOffset):
(WebCore::RenderHighlight::setRenderRange):
(WebCore::RenderHighlight::highlightStateForRenderer):
(WebCore::RenderHighlight::highlightStateForTextBox):
(WebCore::RenderHighlight::rangeForTextBox):
* Source/WebCore/rendering/RenderHighlight.h: Renamed from Source/WebCore/rendering/HighlightData.h.
(WebCore::RenderRange::RenderRange):
(WebCore::RenderRange::start const):
(WebCore::RenderRange::end const):
(WebCore::RenderRange::startOffset const):
(WebCore::RenderRange::endOffset const):
(WebCore::RenderHighlight::RenderHighlight):
(WebCore::RenderHighlight::get const):
(WebCore::RenderHighlight::start const):
(WebCore::RenderHighlight::end const):
(WebCore::RenderHighlight::startOffset const):
(WebCore::RenderHighlight::endOffset const):
* Source/WebCore/rendering/RenderSelection.cpp: Renamed from Source/WebCore/rendering/SelectionRangeData.cpp.
(WebCore::rendererAfterOffset):
(WebCore::isValidRendererForSelection):
(WebCore::containingBlockBelowView):
(WebCore::collectSelectionData):
(WebCore::RenderSelection::RenderSelection):
(WebCore::RenderSelection::set):
(WebCore::RenderSelection::clear):
(WebCore::RenderSelection::repaint const):
(WebCore::RenderSelection::collectBounds const):
(WebCore::RenderSelection::apply):
* Source/WebCore/rendering/RenderSelection.h: Renamed from Source/WebCore/rendering/SelectionRangeData.h.
(WebCore::RenderSelection::bounds const):
(WebCore::RenderSelection::boundsClippedToVisibleContent const):

Canonical link: https://commits.webkit.org/268089@main




More information about the webkit-changes mailing list