[webkit-changes] [WebKit/WebKit] 4fa573: Move more SVG code into legacy

Mon Sep 18 07:02:05 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4fa57316bc40de6e30d160c19c3b0f40441180d3
      https://github.com/WebKit/WebKit/commit/4fa57316bc40de6e30d160c19c3b0f40441180d3
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-09-18 (Mon, 18 Sep 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    R Source/WebCore/rendering/svg/LegacyRenderSVGContainer.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGContainer.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGHiddenContainer.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGHiddenContainer.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGImage.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGImage.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGModelObject.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGModelObject.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGPath.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGPath.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGRect.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGRect.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGRoot.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGShape.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGShape.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGShapeInlines.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.h
    R Source/WebCore/rendering/svg/LegacyRenderSVGViewportContainer.cpp
    R Source/WebCore/rendering/svg/LegacyRenderSVGViewportContainer.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShapeInlines.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.h
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp
    A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.h

  Log Message:
  -----------
  Move more SVG code into legacy
https://bugs.webkit.org/show_bug.cgi?id=261652

Reviewed by Nikolas Zimmermann.

Move more SVG code into legacy so we can concentrate better
on the more modern LBSE implementation.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGContainer.cpp.
(WebCore::LegacyRenderSVGContainer::LegacyRenderSVGContainer):
(WebCore::LegacyRenderSVGContainer::layout):
(WebCore::LegacyRenderSVGContainer::selfWillPaint):
(WebCore::LegacyRenderSVGContainer::paint):
(WebCore::LegacyRenderSVGContainer::addFocusRingRects const):
(WebCore::LegacyRenderSVGContainer::updateCachedBoundaries):
(WebCore::LegacyRenderSVGContainer::nodeAtFloatPoint):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGContainer.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGContainer.h.
(WebCore::LegacyRenderSVGContainer::didTransformToRootUpdate):
(WebCore::LegacyRenderSVGContainer::isObjectBoundingBoxValid const):
(WebCore::LegacyRenderSVGContainer::calculateLocalTransform):
(WebCore::LegacyRenderSVGContainer::calcViewport):
(WebCore::LegacyRenderSVGContainer::applyViewportClip):
(WebCore::LegacyRenderSVGContainer::pointIsInsideViewportClip):
(WebCore::LegacyRenderSVGContainer::determineIfLayoutSizeChanged):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.cpp.
(WebCore::LegacyRenderSVGEllipse::LegacyRenderSVGEllipse):
(WebCore::LegacyRenderSVGEllipse::updateShapeFromElement):
(WebCore::LegacyRenderSVGEllipse::calculateRadiiAndCenter):
(WebCore::LegacyRenderSVGEllipse::fillShape const):
(WebCore::LegacyRenderSVGEllipse::strokeShape const):
(WebCore::LegacyRenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGEllipse::shapeDependentFillContains const):
(WebCore::LegacyRenderSVGEllipse::isRenderingDisabled const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGEllipse.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.cpp.
(WebCore::LegacyRenderSVGForeignObject::LegacyRenderSVGForeignObject):
(WebCore::LegacyRenderSVGForeignObject::foreignObjectElement const):
(WebCore::LegacyRenderSVGForeignObject::paint):
(WebCore::LegacyRenderSVGForeignObject::localToParentTransform const):
(WebCore::LegacyRenderSVGForeignObject::updateLogicalWidth):
(WebCore::LegacyRenderSVGForeignObject::computeLogicalHeight const):
(WebCore::LegacyRenderSVGForeignObject::layout):
(WebCore::LegacyRenderSVGForeignObject::nodeAtFloatPoint):
(WebCore::LegacyRenderSVGForeignObject::offsetFromContainer const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGForeignObject.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGForeignObject.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGHiddenContainer.cpp.
(WebCore::LegacyRenderSVGHiddenContainer::LegacyRenderSVGHiddenContainer):
(WebCore::LegacyRenderSVGHiddenContainer::layout):
(WebCore::LegacyRenderSVGHiddenContainer::paint):
(WebCore::LegacyRenderSVGHiddenContainer::absoluteQuads const):
(WebCore::LegacyRenderSVGHiddenContainer::nodeAtFloatPoint):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGHiddenContainer.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGHiddenContainer.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGImage.cpp.
(WebCore::LegacyRenderSVGImage::LegacyRenderSVGImage):
(WebCore::LegacyRenderSVGImage::willBeDestroyed):
(WebCore::LegacyRenderSVGImage::imageElement const):
(WebCore::LegacyRenderSVGImage::calculateObjectBoundingBox const):
(WebCore::LegacyRenderSVGImage::updateImageViewport):
(WebCore::LegacyRenderSVGImage::layout):
(WebCore::LegacyRenderSVGImage::paint):
(WebCore::LegacyRenderSVGImage::paintForeground):
(WebCore::LegacyRenderSVGImage::invalidateBufferedForeground):
(WebCore::LegacyRenderSVGImage::nodeAtFloatPoint):
(WebCore::LegacyRenderSVGImage::imageChanged):
(WebCore::LegacyRenderSVGImage::addFocusRingRects const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGImage.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGImage.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGModelObject.cpp.
(WebCore::LegacyRenderSVGModelObject::LegacyRenderSVGModelObject):
(WebCore::LegacyRenderSVGModelObject::clippedOverflowRect const):
(WebCore::LegacyRenderSVGModelObject::computeFloatVisibleRectInContainer const):
(WebCore::LegacyRenderSVGModelObject::mapLocalToContainer const):
(WebCore::LegacyRenderSVGModelObject::pushMappingToContainer const):
(WebCore::LegacyRenderSVGModelObject::outlineBoundsForRepaint const):
(WebCore::LegacyRenderSVGModelObject::boundingRects const):
(WebCore::LegacyRenderSVGModelObject::absoluteQuads const):
(WebCore::LegacyRenderSVGModelObject::willBeDestroyed):
(WebCore::LegacyRenderSVGModelObject::styleDidChange):
(WebCore::LegacyRenderSVGModelObject::nodeAtPoint):
(WebCore::getElementCTM):
(WebCore::intersectsAllowingEmpty):
(WebCore::isGraphicsElement):
(WebCore::LegacyRenderSVGModelObject::absoluteFocusRingQuads):
(WebCore::LegacyRenderSVGModelObject::checkIntersection):
(WebCore::LegacyRenderSVGModelObject::checkEnclosure):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGModelObject.h.
(WebCore::LegacyRenderSVGModelObject::element const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGPath.cpp.
(WebCore::LegacyRenderSVGPath::LegacyRenderSVGPath):
(WebCore::LegacyRenderSVGPath::updateShapeFromElement):
(WebCore::LegacyRenderSVGPath::calculateUpdatedStrokeBoundingBox const):
(WebCore::useStrokeStyleToFill):
(WebCore::LegacyRenderSVGPath::strokeShape const):
(WebCore::LegacyRenderSVGPath::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGPath::shouldStrokeZeroLengthSubpath const):
(WebCore::LegacyRenderSVGPath::zeroLengthLinecapPath const):
(WebCore::LegacyRenderSVGPath::zeroLengthSubpathRect const):
(WebCore::LegacyRenderSVGPath::updateZeroLengthSubpaths):
(WebCore::LegacyRenderSVGPath::strokeZeroLengthSubpaths const):
(WebCore::LegacyRenderSVGPath::isRenderingDisabled const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGPath.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGPath.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGRect.cpp.
(WebCore::LegacyRenderSVGRect::LegacyRenderSVGRect):
(WebCore::LegacyRenderSVGRect::rectElement const):
(WebCore::LegacyRenderSVGRect::updateShapeFromElement):
(WebCore::LegacyRenderSVGRect::fillShape const):
(WebCore::LegacyRenderSVGRect::strokeShape const):
(WebCore::LegacyRenderSVGRect::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGRect::shapeDependentFillContains const):
(WebCore::LegacyRenderSVGRect::isRenderingDisabled const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRect.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGRect.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp.
(WebCore::LegacyRenderSVGRoot::LegacyRenderSVGRoot):
(WebCore::LegacyRenderSVGRoot::svgSVGElement const):
(WebCore::LegacyRenderSVGRoot::hasIntrinsicAspectRatio const):
(WebCore::LegacyRenderSVGRoot::calculateIntrinsicSize const):
(WebCore::LegacyRenderSVGRoot::computeIntrinsicRatioInformation const):
(WebCore::LegacyRenderSVGRoot::isEmbeddedThroughSVGImage const):
(WebCore::LegacyRenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument const):
(WebCore::LegacyRenderSVGRoot::computeReplacedLogicalWidth const):
(WebCore::LegacyRenderSVGRoot::computeReplacedLogicalHeight const):
(WebCore::LegacyRenderSVGRoot::layout):
(WebCore::LegacyRenderSVGRoot::shouldApplyViewportClip const):
(WebCore::LegacyRenderSVGRoot::paintReplaced):
(WebCore::LegacyRenderSVGRoot::willBeDestroyed):
(WebCore::LegacyRenderSVGRoot::insertedIntoTree):
(WebCore::LegacyRenderSVGRoot::willBeRemovedFromTree):
(WebCore::LegacyRenderSVGRoot::styleDidChange):
(WebCore::LegacyRenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::LegacyRenderSVGRoot::localToParentTransform const):
(WebCore::LegacyRenderSVGRoot::clippedOverflowRect const):
(WebCore::LegacyRenderSVGRoot::computeFloatVisibleRectInContainer const):
(WebCore::LegacyRenderSVGRoot::mapLocalToContainer const):
(WebCore::LegacyRenderSVGRoot::pushMappingToContainer const):
(WebCore::LegacyRenderSVGRoot::updateCachedBoundaries):
(WebCore::LegacyRenderSVGRoot::nodeAtPoint):
(WebCore::LegacyRenderSVGRoot::hasRelativeDimensions const):
(WebCore::LegacyRenderSVGRoot::addResourceForClientInvalidation):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGRoot.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGShape.cpp.
(WebCore::LegacyRenderSVGShape::LegacyRenderSVGShape):
(WebCore::LegacyRenderSVGShape::updateShapeFromElement):
(WebCore::LegacyRenderSVGShape::isEmpty const):
(WebCore::LegacyRenderSVGShape::fillShape const):
(WebCore::LegacyRenderSVGShape::strokeShape const):
(WebCore::LegacyRenderSVGShape::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGShape::shapeDependentFillContains const):
(WebCore::LegacyRenderSVGShape::fillContains):
(WebCore::LegacyRenderSVGShape::strokeContains):
(WebCore::LegacyRenderSVGShape::layout):
(WebCore::LegacyRenderSVGShape::nonScalingStrokePath const):
(WebCore::LegacyRenderSVGShape::setupNonScalingStrokeContext):
(WebCore::LegacyRenderSVGShape::nonScalingStrokeTransform const):
(WebCore::LegacyRenderSVGShape::shouldGenerateMarkerPositions const):
(WebCore::LegacyRenderSVGShape::fillShape):
(WebCore::LegacyRenderSVGShape::strokeShapeInternal):
(WebCore::LegacyRenderSVGShape::strokeShape):
(WebCore::LegacyRenderSVGShape::fillStrokeMarkers):
(WebCore::LegacyRenderSVGShape::paint):
(WebCore::LegacyRenderSVGShape::addFocusRingRects const):
(WebCore::LegacyRenderSVGShape::isPointInFill):
(WebCore::LegacyRenderSVGShape::isPointInStroke):
(WebCore::LegacyRenderSVGShape::getTotalLength const):
(WebCore::LegacyRenderSVGShape::getPointAtLength const):
(WebCore::LegacyRenderSVGShape::nodeAtFloatPoint):
(WebCore::markerForType):
(WebCore::LegacyRenderSVGShape::markerRect const):
(WebCore::LegacyRenderSVGShape::calculateObjectBoundingBox const):
(WebCore::LegacyRenderSVGShape::calculateStrokeBoundingBox const):
(WebCore::LegacyRenderSVGShape::updateRepaintBoundingBox):
(WebCore::LegacyRenderSVGShape::strokeWidth const):
(WebCore::LegacyRenderSVGShape::hasSmoothStroke const):
(WebCore::LegacyRenderSVGShape::drawMarkers):
(WebCore::LegacyRenderSVGShape::createPath const):
(WebCore::LegacyRenderSVGShape::processMarkerPositions):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShape.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGShape.h.
(WebCore::LegacyRenderSVGShape::setNeedsShapeUpdate):
(WebCore::LegacyRenderSVGShape::hasPath const):
(WebCore::LegacyRenderSVGShape::path const):
(WebCore::LegacyRenderSVGShape::clearPath):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGShapeInlines.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGShapeInlines.h.
(WebCore::LegacyRenderSVGShape::hasNonScalingStroke const):
(WebCore::LegacyRenderSVGShape::graphicsElement const):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.cpp.
(WebCore::LegacyRenderSVGTransformableContainer::LegacyRenderSVGTransformableContainer):
(WebCore::LegacyRenderSVGTransformableContainer::calculateLocalTransform):
(WebCore::LegacyRenderSVGTransformableContainer::graphicsElement):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGTransformableContainer.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGTransformableContainer.h.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.cpp: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGViewportContainer.cpp.
(WebCore::LegacyRenderSVGViewportContainer::LegacyRenderSVGViewportContainer):
(WebCore::LegacyRenderSVGViewportContainer::svgSVGElement const):
(WebCore::LegacyRenderSVGViewportContainer::determineIfLayoutSizeChanged):
(WebCore::LegacyRenderSVGViewportContainer::applyViewportClip):
(WebCore::LegacyRenderSVGViewportContainer::calcViewport):
(WebCore::LegacyRenderSVGViewportContainer::calculateLocalTransform):
(WebCore::LegacyRenderSVGViewportContainer::viewportTransform const):
(WebCore::LegacyRenderSVGViewportContainer::pointIsInsideViewportClip):
(WebCore::LegacyRenderSVGViewportContainer::paint):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGViewportContainer.h: Renamed from Source/WebCore/rendering/svg/LegacyRenderSVGViewportContainer.h.

Canonical link: https://commits.webkit.org/268081@main