[webkit-changes] [WebKit/WebKit] 7d7215: First parseable meta at name=color-scheme should win

sideshowbarker noreply at github.com
Sun Sep 17 07:16:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d7215513fb5d3a7ac39d3809200c0a7aba58bd7
      https://github.com/WebKit/WebKit/commit/7d7215513fb5d3a7ac39d3809200c0a7aba58bd7
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-09-17 (Sun, 17 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-first-valid-applies-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head-expected.txt
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/html/HTMLMetaElement.cpp

  Log Message:
  -----------
  First parseable meta at name=color-scheme should win
https://bugs.webkit.org/show_bug.cgi?id=213563

Reviewed by Aditya Keerthi.

This change gets WebKit conforming to the requirement in the HTML spec
at https://html.spec.whatwg.org/#standard-metadata-names:page's-supported-color-schemes-2
that UAs must respect the first parseable <meta name=color-scheme> value
encountered in tree order. And the change gets WebKit passing the WPT
tests related to that spec requirement.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-first-valid-applies-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::metaElementColorSchemeChanged):
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::removedFromAncestor):
(WebCore::HTMLMetaElement::process):

Canonical link: https://commits.webkit.org/268064@main




More information about the webkit-changes mailing list