[webkit-changes] [WebKit/WebKit] 5b2b95: Rename RenderSelectionInfo to RenderSelectionGeome...

megangardner noreply at github.com
Sat Sep 16 00:03:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5b2b95668aa27f1659143dd2509ce2495bc42cd1
      https://github.com/WebKit/WebKit/commit/5b2b95668aa27f1659143dd2509ce2495bc42cd1
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-09-16 (Sat, 16 Sep 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/rendering/RenderSelectionGeometry.cpp
    A Source/WebCore/rendering/RenderSelectionGeometry.h
    R Source/WebCore/rendering/RenderSelectionInfo.cpp
    R Source/WebCore/rendering/RenderSelectionInfo.h
    M Source/WebCore/rendering/SelectionRangeData.cpp
    M Source/WebCore/rendering/SelectionRangeData.h

  Log Message:
  -----------
  Rename RenderSelectionInfo to RenderSelectionGeometry as part of rename work to clarify classes around highlights.
https://bugs.webkit.org/show_bug.cgi?id=261625
rdar://115575135

Reviewed by Simon Fraser.

Several classes associated with Highlights have a very confusing naming
structure. This is the second rename of several to help clarify
what these classes are and their relationship to each other.

* Source/WebCore/rendering/RenderSelectionGeometry.cpp: Renamed from Source/WebCore/rendering/RenderSelectionInfo.cpp.
(WebCore::RenderSelectionGeometryBase::RenderSelectionGeometryBase):
(WebCore::RenderSelectionGeometryBase::repaintRectangle):
(WebCore::RenderSelectionGeometry::RenderSelectionGeometry):
(WebCore::RenderSelectionGeometry::repaint):
(WebCore::RenderBlockSelectionGeometry::RenderBlockSelectionGeometry):
(WebCore::RenderBlockSelectionGeometry::repaint):
* Source/WebCore/rendering/RenderSelectionGeometry.h: Renamed from Source/WebCore/rendering/RenderSelectionInfo.h.
(WebCore::RenderSelectionGeometryBase::repaintContainer const):
(WebCore::RenderSelectionGeometryBase::state const):
(WebCore::RenderSelectionGeometry::collectedSelectionQuads const):
(WebCore::RenderSelectionGeometry::rect const):
(WebCore::RenderBlockSelectionGeometry::rects const):

Canonical link: https://commits.webkit.org/268051@main




More information about the webkit-changes mailing list