[webkit-changes] [WebKit/WebKit] 3d6388: AX: Fix to handle author error roles

Hunseop Jeong noreply at github.com
Fri Sep 15 09:54:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d6388b4ceebeaf49590c8079929262246cfc100
      https://github.com/WebKit/WebKit/commit/3d6388b4ceebeaf49590c8079929262246cfc100
  Author: Hunseop Jeong <hs85jeong at gmail.com>
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
    M LayoutTests/accessibility/aria-namefrom-author.html
    M LayoutTests/accessibility/roles-computedRoleString.html
    M LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/form-roles-expected.txt
    M LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: Fix to handle author error roles
https://bugs.webkit.org/show_bug.cgi?id=261542
rdar://problem/115462091

Reviewed by Tyler Wilcock.

This commit fixes the wai-aria/role/form-roles test[1]. According to the
ARIA spec[2], in situations where an author has not specified names for
the form and region landmarks, it is considered as authoring error. If a
valid fallback role had been specified, or if the element had an implicit
ARIA role, then user agents would continue to expose that role instead.

[1]: https://wpt.fyi/results/wai-aria/role/form-roles.html
[2]: https://w3c.github.io/aria/#document-handling_author-errors_roles

* LayoutTests/accessibility/aria-namefrom-author.html:
* LayoutTests/accessibility/roles-computedRoleString.html:
* LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/form-roles-expected.txt:
* LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):

Canonical link: https://commits.webkit.org/268025@main




More information about the webkit-changes mailing list