[webkit-changes] [WebKit/WebKit] 692023: Rename HighlightRangeData to HighlightRange as par...
megangardner
noreply at github.com
Fri Sep 15 08:52:00 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6920239d3ba0a14c48ca903c33218e4f4dafe6b1
https://github.com/WebKit/WebKit/commit/6920239d3ba0a14c48ca903c33218e4f4dafe6b1
Author: Megan Gardner <megan_gardner at apple.com>
Date: 2023-09-15 (Fri, 15 Sep 2023)
Changed paths:
M Source/WebCore/Modules/highlight/Highlight.cpp
M Source/WebCore/Modules/highlight/Highlight.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/rendering/HighlightData.cpp
M Source/WebCore/rendering/HighlightData.h
M Source/WebCore/rendering/MarkedText.cpp
M Source/WebCore/rendering/RenderReplaced.cpp
M Source/WebCore/testing/Internals.cpp
Log Message:
-----------
Rename HighlightRangeData to HighlightRange as part of rename work to clarify classes around highlights.
https://bugs.webkit.org/show_bug.cgi?id=261594
rdar://115542469
Reviewed by Tim Horton.
Several classes associated with Highlights have a very confusing naming
structure. This is the first rename of several to help clarify
what these classes are and their relationship to each other.
* Source/WebCore/Modules/highlight/Highlight.cpp:
(WebCore::Highlight::Highlight):
(WebCore::Highlight::initializeSetLike):
(WebCore::Highlight::removeFromSetLike):
(WebCore::Highlight::clearFromSetLike):
(WebCore::Highlight::addToSetLike):
(WebCore::Highlight::repaint):
* Source/WebCore/Modules/highlight/Highlight.h:
(WebCore::HighlightRange::create):
(WebCore::HighlightRange::HighlightRange):
(WebCore::Highlight::highlightRanges const):
(WebCore::HighlightRangeData::create): Deleted.
(WebCore::HighlightRangeData::range const): Deleted.
(WebCore::HighlightRangeData::startPosition const): Deleted.
(WebCore::HighlightRangeData::setStartPosition): Deleted.
(WebCore::HighlightRangeData::endPosition const): Deleted.
(WebCore::HighlightRangeData::setEndPosition): Deleted.
(WebCore::HighlightRangeData::HighlightRangeData): Deleted.
(WebCore::Highlight::rangesData const): Deleted.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::collectRangeDataFromRegister):
(WebCore::Document::updateHighlightPositions):
* Source/WebCore/dom/Document.h:
* Source/WebCore/rendering/HighlightData.cpp:
(WebCore::HighlightData::setRenderRange):
* Source/WebCore/rendering/HighlightData.h:
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForHighlights):
* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::calculateHighlightColor const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::numberOfAppHighlights):
Canonical link: https://commits.webkit.org/268022@main
More information about the webkit-changes
mailing list