[webkit-changes] [WebKit/WebKit] 62aac5: alignment-baseline should not support the value "a...

Karl Dubost noreply at github.com
Thu Sep 14 17:12:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62aac54b7bcd4f14d3a4c41c3a09b24f50e50151
      https://github.com/WebKit/WebKit/commit/62aac54b7bcd4f14d3a4c41c3a09b24f50e50151
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2023-09-14 (Thu, 14 Sep 2023)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/alignment-baseline-no-interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/rendering/style/SVGRenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.h
    M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp

  Log Message:
  -----------
  alignment-baseline should not support the value "auto"
https://bugs.webkit.org/show_bug.cgi?id=260346
rdar://114024256

Reviewed by Tim Nguyen.

The spec defines alignment-baseline without the value auto
and the initial value being baseline.
https://drafts.csswg.org/css-inline/#alignment-baseline-property

This will also make pass the relevant WPT test
http://wpt.live/css/css-inline/parsing/alignment-baseline-invalid.html

* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/animation/alignment-baseline-no-interpolation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-inline/parsing/alignment-baseline-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialAlignmentBaseline):
* Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/SVGRenderStyleDefs.h:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:
(WebCore::SVGTextLayoutEngineBaseline::dominantBaselineToAlignmentBaseline const):
(WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift const):

Canonical link: https://commits.webkit.org/268008@main




More information about the webkit-changes mailing list