[webkit-changes] [WebKit/WebKit] 76fdca: resetFontRangeIfNeeded() accidentally copies its i...

Myles C. Maxfield noreply at github.com
Wed Sep 13 23:17:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 76fdcab415eae53442a8c12755ee3fbcbfd75c28
      https://github.com/WebKit/WebKit/commit/76fdcab415eae53442a8c12755ee3fbcbfd75c28
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/WidthIterator.cpp

  Log Message:
  -----------
  resetFontRangeIfNeeded() accidentally copies its inout param, rather than taking it by reference
https://bugs.webkit.org/show_bug.cgi?id=260687
rdar://114416548

Reviewed by Cameron McCormack.

resetFontRangeIfNeeded() attempts to reset the TextIterator that's passed into it, except it
accidentally copies the TextIterator, thereby having no effect on the caller.

This patch needs a test.

* Source/WebCore/platform/graphics/WidthIterator.cpp:
(WebCore::resetFontRangeIfNeeded):

Canonical link: https://commits.webkit.org/267981@main




More information about the webkit-changes mailing list