[webkit-changes] [WebKit/WebKit] 6f6557: Move off of UIKit SPI: `_UISheetDetent`

megangardner noreply at github.com
Wed Sep 13 19:15:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f6557cd266c66f828329c38ff521fc8e2005752
      https://github.com/WebKit/WebKit/commit/6f6557cd266c66f828329c38ff521fc8e2005752
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm

  Log Message:
  -----------
  Move off of UIKit SPI: `_UISheetDetent`
https://bugs.webkit.org/show_bug.cgi?id=261540
rdar://115331913

Reviewed by Wenson Hsieh.

These deprecated SPIs have existing public API replacements:

• `_UISheetDetent` -> `UISheetPresentationControllerDetent`
• `_UISheetPresentationController` -> `UISheetPresentationController`
• `+_mediumDetent` -> `+mediumDetent`
• `+_largeDetent` -> `+largeDetent`
• `_widthFollowsPreferredContentSizeWhenBottomAttached` -> `widthFollowsPreferredContentSizeWhenEdgeAttached`
• `_wantsBottomAttachedInCompactHeight` -> `prefersEdgeAttachedInCompactHeight`

Therefore, we can simply adopt these 1-1 replacements and remove their declarations in SPI headers.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectMultiplePicker configurePresentation]):

Canonical link: https://commits.webkit.org/267978@main




More information about the webkit-changes mailing list