[webkit-changes] [WebKit/WebKit] 2a89fc: Remove WebPushD related asserts

Brady Eidson noreply at github.com
Wed Sep 13 15:59:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a89fcf5e36283edefba5d66662b71db23cf6952
      https://github.com/WebKit/WebKit/commit/2a89fcf5e36283edefba5d66662b71db23cf6952
  Author: Brady Eidson <beidson at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm

  Log Message:
  -----------
  Remove WebPushD related asserts
https://bugs.webkit.org/show_bug.cgi?id=261530

Reviewed by Chris Dumez.

Most engineers working with ToT WebKit are not also going to take the step to use ToT webpushd.
Their app instead connects to the System install of webpushd.

It's fine that web push doesn't *work* in this config, but not fine that these ASSERTs fire.

Remove the nuisance!

* Source/WebKit/NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
(WebKit::WebPushD::Connection::performSendWithAsyncReplyWithoutUsingIPCConnection const):

Canonical link: https://commits.webkit.org/267971@main




More information about the webkit-changes mailing list