[webkit-changes] [WebKit/WebKit] 2e6a38: AX: Fix failing WPT menu-roles test

Hunseop Jeong noreply at github.com
Wed Sep 13 09:45:39 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e6a3871e57140c019de09c3aa2a4fdcfe46a9e0
      https://github.com/WebKit/WebKit/commit/2e6a3871e57140c019de09c3aa2a4fdcfe46a9e0
  Author: Hunseop Jeong <hs85jeong at gmail.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M LayoutTests/accessibility/roles-computedRoleString.html
    A LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/menu-roles-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/wai-aria/role/menu-roles.html
    M LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: Fix failing WPT menu-roles test
https://bugs.webkit.org/show_bug.cgi?id=261457
rdar://problem/115336495

Reviewed by Tyler Wilcock.

Currently, some of the WPT menu-roles tests[1] have failed. According to
the ARIA spec[2], if a menuitem has a group as first parent and a menu
or menubar as the second parent, it must be a menuitem role.

[1]: https://wpt.fyi/results/wai-aria/role/menu-roles.html
[2]: https://w3c.github.io/aria/#menu

* LayoutTests/accessibility/roles-computedRoleString.html:
* LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent const):

Canonical link: https://commits.webkit.org/267955@main




More information about the webkit-changes mailing list