[webkit-changes] [WebKit/WebKit] c4e648: Allow grandparent site-isolated iframe to be in sa...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4e648e277442a4ebd1f978cae940eea52890a53
      https://github.com/WebKit/WebKit/commit/c4e648e277442a4ebd1f978cae940eea52890a53
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Allow grandparent site-isolated iframe to be in same process as grandchild
https://bugs.webkit.org/show_bug.cgi?id=261507
rdar://115426049

Reviewed by J Pascoe.

Two small fixes are needed to make this case not crash.

1. In DocumentLoader::willSendRequest, we hit the case where there is no parent LocalFrame.
   In this case, just continue the load like we do in other cases in this function.
2. The transaction ID should only be incremented once per process, independent of how many
   root frames that process has.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updateRendering):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267953@main