[webkit-changes] [WebKit/WebKit] bc011e: [webkitpy] Detection of GTK4 is broken

Claudio Saavedra noreply at github.com
Wed Sep 13 07:07:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc011e53e91781e58ab5fc3a91795eba69d836ea
      https://github.com/WebKit/WebKit/commit/bc011e53e91781e58ab5fc3a91795eba69d836ea
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/port/gtk.py
    M Tools/Scripts/webkitpy/port/gtk_unittest.py

  Log Message:
  -----------
  [webkitpy] Detection of GTK4 is broken
https://bugs.webkit.org/show_bug.cgi?id=261503

Reviewed by Adrian Perez de Castro.

The name of the current binary for the gtk4 library is different,
update the method to actually find all library binaries.

 * Tools/Scripts/webkitpy/port/gtk.py:
 (GtkPort._is_gtk4_build):
 * Tools/Scripts/webkitpy/port/gtk_unittest.py:
 (GtkPortTest.test_gtk4_expectations_binary_only):
 (GtkPortTest.test_gtk_expectations_both_binaries):

Canonical link: https://commits.webkit.org/267946@main




More information about the webkit-changes mailing list