[webkit-changes] [WebKit/WebKit] 119022: Remove assertion in WebFrameLoaderClient::broadcas...

Alex Christensen noreply at github.com
Wed Sep 13 06:08:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 119022bfe214985e45c50444d3d1b23b5fcd8fd2
      https://github.com/WebKit/WebKit/commit/119022bfe214985e45c50444d3d1b23b5fcd8fd2
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Remove assertion in WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses
https://bugs.webkit.org/show_bug.cgi?id=261501
rdar://115421153

Reviewed by J Pascoe.

The assertion is hit during teardown sometimes when doing multiple reloads on a page with site-isolated iframes.
It is fine to do nothing if the page has already been torn down because there is no RemotePageProxy to send a message to,
and there are no other processes that have a frame that needs to be destroyed.

* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::broadcastFrameRemovalToOtherProcesses):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/267942@main




More information about the webkit-changes mailing list