[webkit-changes] [WebKit/WebKit] 5f5c97: Move Context2D testing properties from HTMLCanvasE...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f5c97abe1092e1c087bdd5fffd3ba3c1c5fea33
      https://github.com/WebKit/WebKit/commit/5f5c97abe1092e1c087bdd5fffd3ba3c1c5fea33
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html
    M Source/WebCore/html/CanvasBase.cpp
    M Source/WebCore/html/CanvasBase.h
    M Source/WebCore/html/HTMLCanvasElement.cpp
    M Source/WebCore/html/HTMLCanvasElement.h
    M Source/WebCore/html/OffscreenCanvas.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext.h
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
    M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h
    M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h
    M Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Move Context2D testing properties from HTMLCanvasElement to context options
https://bugs.webkit.org/show_bug.cgi?id=261404
rdar://115282259

Reviewed by Matt Woodrow.

Context2D testing options should be related to the rendering context,
not to the canvas element. Move the property
avoidIOSurfaceSizeCheckInWebProcess as general purpose context 2d
option "renderingMode". This enables testing the various backends
comprehensively in the future.

* LayoutTests/fast/canvas/image-buffer-iosurface-disabled.html:
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::allocateImageBuffer const):
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer const):
(WebCore::HTMLCanvasElement::setAvoidIOSurfaceSizeCheckInWebProcessForTesting): Deleted.
* Source/WebCore/html/HTMLCanvasElement.h:
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::transferToImageBitmap):
(WebCore::OffscreenCanvas::createImageBuffer const):
* Source/WebCore/html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::adjustImageBufferOptionsForTesting):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::adjustImageBufferOptionsForTesting):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2DSettings.idl:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::avoidIOSurfaceSizeCheckInWebProcess): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/267934@main