[webkit-changes] [WebKit/WebKit] 502533: PlaybackSessionManagerProxy should use WeakPtrs

aestes noreply at github.com
Tue Sep 12 13:42:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 50253341f5a3fc15e3bcb960efb285c4a5ee8529
      https://github.com/WebKit/WebKit/commit/50253341f5a3fc15e3bcb960efb285c4a5ee8529
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm

  Log Message:
  -----------
  PlaybackSessionManagerProxy should use WeakPtrs
https://bugs.webkit.org/show_bug.cgi?id=261222
rdar://115071751

Reviewed by Jer Noble.

Changed PlaybackSessionModelContext::m_manager from a PlaybackSessionManagerProxy* to a
WeakPtr<PlaybackSessionManagerProxy>. Changed PlaybackSessionManagerProxy::m_page from a
WebPageProxy* to a WeakPtr<WebPageProxy>. Removed the unused
PlaybackSessionModelContext::invalidate() function.

* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::PlaybackSessionModelContext):
(WebKit::PlaybackSessionManagerProxy::PlaybackSessionManagerProxy):

Canonical link: https://commits.webkit.org/267916@main




More information about the webkit-changes mailing list