[webkit-changes] [WebKit/WebKit] 6ec1bb: Use WeakHashSet<T> / ThreadSafeWeakHashSet<T> inst...

Chris Dumez noreply at github.com
Tue Sep 12 12:33:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ec1bbcc639f159ceb4986135267b1b609c4acdb
      https://github.com/WebKit/WebKit/commit/6ec1bbcc639f159ceb4986135267b1b609c4acdb
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm
    M Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp
    M Source/WebCore/platform/graphics/FontCache.cpp
    M Source/WebCore/rendering/RenderLayerFilters.cpp
    M Source/WebCore/rendering/style/StyleImage.h
    M Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
    M Source/WebCore/rendering/svg/RenderSVGResourceContainer.h
    M Source/WebCore/rendering/svg/SVGContainerLayout.cpp
    M Source/WebCore/rendering/svg/SVGRenderSupport.cpp
    M Source/WebCore/svg/SVGCursorElement.cpp
    M Source/WebCore/svg/SVGCursorElement.h
    M Source/WebCore/svg/SVGRadialGradientElement.cpp
    M Source/WebCore/workers/WorkerOrWorkletThread.cpp
    M Source/WebCore/workers/WorkerOrWorkletThread.h
    M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp
    M Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h

  Log Message:
  -----------
  Use WeakHashSet<T> / ThreadSafeWeakHashSet<T> instead of HashSet<T*> more in WebCore
https://bugs.webkit.org/show_bug.cgi?id=261430

Reviewed by Darin Adler.

Use WeakHashSet<T> / ThreadSafeWeakHashSet<T> instead of HashSet<T*> more in WebCore,
for extra safety.

* Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::ResourceUsageThread::platformCollectCPUData):
* Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp:
(WebCore::ResourceUsageThread::platformCollectCPUData):
* Source/WebCore/platform/graphics/FontCache.cpp:
(WebCore::dispatchToAllFontCaches):
* Source/WebCore/rendering/RenderLayerFilters.cpp:
(WebCore::RenderLayerFilters::updateReferenceFilterClients):
(WebCore::RenderLayerFilters::removeReferenceFilterClients):
* Source/WebCore/rendering/style/StyleImage.h:
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
(WebCore::RenderSVGResourceContainer::addClient):
(WebCore::RenderSVGResourceContainer::removeClient):
(WebCore::RenderSVGResourceContainer::addClientRenderLayer):
(WebCore::RenderSVGResourceContainer::removeClientRenderLayer):
* Source/WebCore/rendering/svg/RenderSVGResourceContainer.h:
* Source/WebCore/rendering/svg/SVGContainerLayout.cpp:
(WebCore::SVGContainerLayout::layoutChildren):
* Source/WebCore/rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
* Source/WebCore/svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::~SVGCursorElement):
(WebCore::SVGCursorElement::addClient):
(WebCore::SVGCursorElement::removeClient):
(WebCore::SVGCursorElement::svgAttributeChanged):
* Source/WebCore/svg/SVGCursorElement.h:
* Source/WebCore/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
* Source/WebCore/workers/WorkerOrWorkletThread.cpp:
(WebCore::WorkerOrWorkletThread::workerOrWorkletThreads):
(WebCore::WorkerOrWorkletThread::WorkerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::~WorkerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::workerOrWorkletThread):
(WebCore::WorkerOrWorkletThread::destroyWorkerGlobalScope):
(WebCore::WorkerOrWorkletThread::releaseFastMallocFreeMemoryInAllThreads):
(WebCore::WorkerOrWorkletThread::addChildThread):
(WebCore::WorkerOrWorkletThread::removeChildThread):
(WebCore::WorkerOrWorkletThread::workerOrWorkletThreadsLock): Deleted.
(): Deleted.
* Source/WebCore/workers/WorkerOrWorkletThread.h:
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::allServiceWorkerThreadProxies):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::~ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::networkStateChanged):
(): Deleted.
* Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:

Canonical link: https://commits.webkit.org/267914@main




More information about the webkit-changes mailing list