[webkit-changes] [WebKit/WebKit] 2d5d6f: Create a helper for targeting domain names in Quir...

[Karl Dubost]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d5d6f169a10b77912924eef14c9954ee545e693
      https://github.com/WebKit/WebKit/commit/2d5d6f169a10b77912924eef14c9954ee545e693
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h

  Log Message:
  -----------
  Create a helper for targeting domain names in Quirks.cpp
https://bugs.webkit.org/show_bug.cgi?id=260938
rdar://114737751

Reviewed by Timothy Hatcher.

Adds the helper isDomain() to give more regularity to the code and have
a uniform way of testing the domain name. There is probably more to do
to be able to address the other cases.

This also uses this new helper to convert the current domain matchings.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::isDomain const):
(WebCore::Quirks::needsFormControlToBeMouseFocusable const):
(WebCore::Quirks::needsSeekingSupportDisabled const):
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
(WebCore::Quirks::shouldAutoplayWebAudioForArbitraryUserGesture const):
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
(WebCore::Quirks::shouldDisableContentChangeObserver const):
(WebCore::Quirks::shouldDisableContentChangeObserverTouchEventAdjustment const):
(WebCore::Quirks::shouldTooltipPreventFromProceedingWithClick const):
(WebCore::Quirks::isNeverRichlyEditableForTouchBar const):
(WebCore::Quirks::shouldDispatchSyntheticMouseEventsWhenModifyingSelection const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):
(WebCore::Quirks::shouldPreventPointerMediaQueryFromEvaluatingToCoarse const):
(WebCore::Quirks::shouldPreventDispatchOfTouchEvent const): Deleted.
(WebCore::Quirks::shouldSynthesizeTouchEvents const): Deleted.
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const): Deleted.
(WebCore::Quirks::shouldDisablePointerEventsQuirk const): Deleted.
(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const): Deleted.
(WebCore::Quirks::needsGMailOverflowScrollQuirk const): Deleted.
(WebCore::Quirks::needsYouTubeOverflowScrollQuirk const): Deleted.
(WebCore::Quirks::needsFullscreenDisplayNoneQuirk const): Deleted.
(WebCore::Quirks::needsWeChatScrollingQuirk const): Deleted.
(WebCore::Quirks::shouldOmitHTMLDocumentSupportedPropertyNames): Deleted.
(WebCore::Quirks::shouldSilenceResizeObservers const): Deleted.
(WebCore::Quirks::shouldSilenceWindowResizeEvents const): Deleted.
(WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const): Deleted.
(WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const): Deleted.
(WebCore::Quirks::shouldUseLegacySelectPopoverDismissalBehaviorInDataActivation const): Deleted.
(WebCore::Quirks::shouldIgnoreAriaForFastPathContentObservationCheck const): Deleted.
(WebCore::isWikipediaDomain): Deleted.
(WebCore::Quirks::shouldIgnoreViewportArgumentsToAvoidExcessiveZoom const): Deleted.
(WebCore::Quirks::shouldOpenAsAboutBlank const): Deleted.
(WebCore::Quirks::needsPreloadAutoQuirk const): Deleted.
(WebCore::Quirks::shouldBypassBackForwardCache const): Deleted.
(WebCore::Quirks::shouldBypassAsyncScriptDeferring const): Deleted.
(WebCore::Quirks::shouldMakeEventListenerPassive): Deleted.
(WebCore::Quirks::shouldEnableLegacyGetUserMediaQuirk const): Deleted.
(WebCore::Quirks::needsCanPlayAfterSeekedQuirk const): Deleted.
(WebCore::Quirks::shouldLayOutAtMinimumWindowWidthWhenIgnoringScalingConstraints const): Deleted.
(WebCore::Quirks::shouldAvoidPastingImagesAsWebContent const): Deleted.
(WebCore::isKinjaLoginAvatarElement): Deleted.
(WebCore::Quirks::isMicrosoftTeamsRedirectURL): Deleted.
(WebCore::isStorageAccessQuirkDomainAndElement): Deleted.
(WebCore::Quirks::hasStorageAccessForAllLoginDomains): Deleted.
(WebCore::Quirks::staticRadioPlayerURLString): Deleted.
(WebCore::Quirks::requestStorageAccessAndHandleClick const): Deleted.
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const): Deleted.
(WebCore::Quirks::needsVP9FullRangeFlagQuirk const): Deleted.
(WebCore::Quirks::requiresUserGestureToPauseInPictureInPicture const): Deleted.
(WebCore::Quirks::requiresUserGestureToLoadInPictureInPicture const): Deleted.
(WebCore::Quirks::blocksReturnToFullscreenFromPictureInPictureQuirk const): Deleted.
(WebCore::Quirks::blocksEnteringStandardFullscreenFromPictureInPictureQuirk const): Deleted.
(WebCore::Quirks::shouldDisableEndFullscreenEventWhenEnteringPictureInPictureFromFullscreenQuirk const): Deleted.
(WebCore::Quirks::shouldDelayFullscreenEventWhenExitingPictureInPictureQuirk const): Deleted.
(WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture): Deleted.
(WebCore::Quirks::allowLayeredFullscreenVideos const): Deleted.
(WebCore::Quirks::shouldEnableApplicationCacheQuirk const): Deleted.
(WebCore::Quirks::shouldEnableFontLoadingAPIQuirk const): Deleted.
(WebCore::Quirks::needsVideoShouldMaintainAspectRatioQuirk const): Deleted.
(WebCore::Quirks::shouldExposeShowModalDialog const): Deleted.
(WebCore::Quirks::shouldNavigatorPluginsBeEmpty const): Deleted.
(WebCore::Quirks::shouldDisableLazyIframeLoadingQuirk const): Deleted.
(WebCore::Quirks::shouldDisableFetchMetadata const): Deleted.
(WebCore::Quirks::shouldDisablePushStateFilePathRestrictions const): Deleted.
(WebCore::Quirks::shouldDisablePopoverAttributeQuirk const): Deleted.
(WebCore::Quirks::needsConfigurableIndexedPropertiesQuirk const): Deleted.
(WebCore::Quirks::shouldEnableCanvas2DAdvancedPrivacyProtectionQuirk const): Deleted.
(WebCore::Quirks::advancedPrivacyProtectionSubstituteDataURLForText const): Deleted.
(WebCore::Quirks::needsResettingTransitionCancelsRunningTransitionQuirk const): Deleted.
(WebCore::Quirks::shouldStarBeFeaturePolicyDefaultValue const): Deleted.
* Source/WebCore/page/Quirks.h:

Canonical link: https://commits.webkit.org/267907@main