[webkit-changes] [WebKit/WebKit] 2115ac: FKA: The auto-generated label in a <details> eleme...

Ryosuke Niwa noreply at github.com
Tue Sep 12 06:06:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2115ac47e42743ef7d1178995ffe8968c0bd3878
      https://github.com/WebKit/WebKit/commit/2115ac47e42743ef7d1178995ffe8968c0bd3878
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    A LayoutTests/fast/html/details-no-summary-keyboard-show-hide-expected.txt
    A LayoutTests/fast/html/details-no-summary-keyboard-show-hide.html
    M LayoutTests/fast/shadow-dom/focus-across-details-element-expected.txt
    M LayoutTests/fast/shadow-dom/focus-across-details-element.html
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/html/HTMLDetailsElement.h

  Log Message:
  -----------
  FKA: The auto-generated label in a <details> element without a <summary> is not keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=78499

Reviewed by Tim Nguyen.

The bug was caused by the summary element in details element's shadow tree getting skipped during
sequential focus navigation because it has custom focus logic. Fixed the bug by removing this.

The test was originally written by Arko Saha.

* LayoutTests/fast/html/details-no-summary-keyboard-show-hide-expected.txt: Added.
* LayoutTests/fast/html/details-no-summary-keyboard-show-hide.html: Added.
* LayoutTests/fast/shadow-dom/focus-across-details-element-expected.txt: Rebaselined the test. New
behavior matches that of Chrome.
* LayoutTests/fast/shadow-dom/focus-across-details-element.html: Ditto.
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/html/HTMLDetailsElement.h:

Canonical link: https://commits.webkit.org/267899@main




More information about the webkit-changes mailing list