[webkit-changes] [WebKit/WebKit] c81134: OffscreenCanvas WebGL does not produce console log...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8113478349e7c301c177862a4a70e75f1bd9fc4
      https://github.com/WebKit/WebKit/commit/c8113478349e7c301c177862a4a70e75f1bd9fc4
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    A LayoutTests/webgl/offscreen-webgl-errors-to-console-expected.txt
    A LayoutTests/webgl/offscreen-webgl-errors-to-console.html
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h

  Log Message:
  -----------
  OffscreenCanvas WebGL does not produce console log messages
https://bugs.webkit.org/show_bug.cgi?id=261400
rdar://115275708

Reviewed by Dan Glastonbury.

Use ScriptExecutionContext of the CanvasBase to add the console message.
This works for HTMLElement as well as OffscreenCanvas.

Do not reset the error counter on context restore. The counter is logical
to be for the context object, not for the underlying OpenGL context.

* Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::initializeContextState):
(WebCore::WebGLRenderingContextBase::shouldPrintToConsole const):
(WebCore::WebGLRenderingContextBase::printToConsole):
* Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: https://commits.webkit.org/267895@main