[webkit-changes] [WebKit/WebKit] e7cf80: Regression(267576 at main) Closing Remote Web Inspect...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7cf800e186ca92213045a7915e0d880a46c88e8
      https://github.com/WebKit/WebKit/commit/e7cf800e186ca92213045a7915e0d880a46c88e8
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm

  Log Message:
  -----------
  Regression(267576 at main) Closing Remote Web Inspector session crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=261443

Reviewed by Patrick Angle.

Make sure we unregister the client in [_WKRemoteWebInspectorViewController dealloc] that
we registered in this init function since we're about to destroy the client. However, the
RemoteWebInspectorUIProxy::m_client will point to the client being destroyed, which will
hit a RELEASE_ASSERT() now that `RemoteWebInspectorUIProxy::m_client` is a CheckedPtr.

* Source/WebKit/UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
(-[_WKRemoteWebInspectorViewController dealloc]):

Canonical link: https://commits.webkit.org/267886@main