[webkit-changes] [WebKit/WebKit] 60c71c: [css-shapes] Implement rect() shape

Tim Nguyen noreply at github.com
Mon Sep 11 07:50:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60c71caf6ae8f78fcf776c5441ebdcd14f8cc5bf
      https://github.com/WebKit/WebKit/commit/60c71caf6ae8f78fcf776c5441ebdcd14f8cc5bf
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-xywh-rect-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-006-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt
    M Source/WebCore/css/BasicShapeFunctions.cpp
    M Source/WebCore/css/CSSBasicShapes.cpp
    M Source/WebCore/css/CSSBasicShapes.h
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/style/BasicShapes.cpp
    M Source/WebCore/rendering/style/BasicShapes.h

  Log Message:
  -----------
  [css-shapes] Implement rect() shape
https://bugs.webkit.org/show_bug.cgi?id=261363
rdar://114479534

Reviewed by Cameron McCormack.

Implement rect(top right bottom left [round ...]?) syntax.

https://drafts.csswg.org/css-shapes-1/#funcdef-basic-shape-rect

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/clip-path-interpolation-xywh-rect-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/clip-path-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/animation/offset-path-interpolation-006-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/parsing/offset-path-parsing-valid-expected.txt:
* Source/WebCore/css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::convertToLengthOrAuto):
(WebCore::basicShapeForValue):
* Source/WebCore/css/CSSBasicShapes.cpp:
(WebCore::buildRadiiString):
(WebCore::buildXywhString):
(WebCore::CSSRectShapeValue::CSSRectShapeValue):
(WebCore::CSSRectShapeValue::create):
(WebCore::CSSRectShapeValue::equals const):
(WebCore::buildRectString):
(WebCore::CSSRectShapeValue::customCSSText const):
(WebCore::buildInsetString):
* Source/WebCore/css/CSSBasicShapes.h:
(WebCore::CSSRectShapeValue::top const):
(WebCore::CSSRectShapeValue::right const):
(WebCore::CSSRectShapeValue::bottom const):
(WebCore::CSSRectShapeValue::left const):
(WebCore::CSSRectShapeValue::topLeftRadius const):
(WebCore::CSSRectShapeValue::topRightRadius const):
(WebCore::CSSRectShapeValue::bottomRightRadius const):
(WebCore::CSSRectShapeValue::bottomLeftRadius const):
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isRectShape const):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeBasicShapeRect):
(WebCore::CSSPropertyParserHelpers::consumeBasicShape):
* Source/WebCore/rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeRect::create):
(WebCore::BasicShapeRect::BasicShapeRect):
(WebCore::BasicShapeRect::clone const):
(WebCore::BasicShapeRect::operator== const):
(WebCore::BasicShapeRect::path):
(WebCore::BasicShapeRect::canBlend const):
(WebCore::BasicShapeRect::blend const):
(WebCore::BasicShapeRect::dump const):
* Source/WebCore/rendering/style/BasicShapes.h:

Canonical link: https://commits.webkit.org/267863@main




More information about the webkit-changes mailing list