[webkit-changes] [WebKit/WebKit] 4f581e: [IFC][Partial layout] Enable appending inline box ...

Alan Baradlay noreply at github.com
Sat Sep 9 21:21:26 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f581efcb10612b91a638c0ce8618c50a385599b
      https://github.com/WebKit/WebKit/commit/4f581efcb10612b91a638c0ce8618c50a385599b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    A LayoutTests/fast/text/simple-text-inside-inline-box-append-with-br-expected.html
    A LayoutTests/fast/text/simple-text-inside-inline-box-append-with-br.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  [IFC][Partial layout] Enable appending inline box content
https://bugs.webkit.org/show_bug.cgi?id=261365

Reviewed by Antti Koivisto.

This patch enables appending type of content mutation with inline boxes.

 fast/text/emoji-num-glyphs.html
 editing/selection/move-by-character-brute-force.html
 fast/innerHTML/identical-mutations.html
tests were all timing out due to the lack of partial layout.

* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::isSupportedContent):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::insertedIntoTree):
(WebCore::LayoutIntegration::LineLayout::shouldSwitchToLegacyOnInvalidation const): Deleted.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.h:
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Canonical link: https://commits.webkit.org/267837@main




More information about the webkit-changes mailing list