[webkit-changes] [WebKit/WebKit] c42089: [IFC][Partial layout] Only run post-layout adjustm...

Alan Baradlay noreply at github.com
Sat Sep 9 07:58:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c420890e5d1527a8e8481beef54153b40382884a
      https://github.com/WebKit/WebKit/commit/c420890e5d1527a8e8481beef54153b40382884a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h

  Log Message:
  -----------
  [IFC][Partial layout] Only run post-layout adjustments on the newly constructed inline content
https://bugs.webkit.org/show_bug.cgi?id=261350

Reviewed by Antti Koivisto.

FirstBox/LastBox/needs visual reordering/etc bits do not change unless layout has been performed on that line/boxes.
Let's just run such adjustments on the news constructed content (This is surprising expensive and shows up on microbenchmarks where
hundreds of lines are being constructed one by one.)

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:
(WebCore::InlineDisplay::Line::lastBoxIndex const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):
(WebCore::LayoutIntegration::InlineContentBuilder::updateLineOverflow const):
(WebCore::LayoutIntegration::InlineContentBuilder::adjustDisplayLines const):
(WebCore::LayoutIntegration::InlineContentBuilder::computeIsFirstIsLastBoxForInlineContent const):
(WebCore::LayoutIntegration::InlineContentBuilder::updateIfTextRenderersNeedVisualReordering const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.h:

Canonical link: https://commits.webkit.org/267830@main




More information about the webkit-changes mailing list