[webkit-changes] [WebKit/WebKit] dc25ee: Make `VTTRegion.lines` unsigned long type

Kohei Ueno noreply at github.com
Sat Sep 9 04:54:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc25ee48a22ae9eea1ae639438c2ed20122f23af
      https://github.com/WebKit/WebKit/commit/dc25ee48a22ae9eea1ae639438c2ed20122f23af
  Author: Kohei Ueno <kohei.ueno119 at gmail.com>
  Date:   2023-09-09 (Sat, 09 Sep 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/lines-expected.txt
    M LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt
    M LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
    M Source/WebCore/html/track/VTTRegion.cpp
    M Source/WebCore/html/track/VTTRegion.h
    M Source/WebCore/html/track/VTTRegion.idl
    M Source/WebCore/html/track/VTTScanner.cpp
    M Source/WebCore/html/track/VTTScanner.h
    M Source/WebCore/html/track/WebVTTParser.cpp

  Log Message:
  -----------
  Make `VTTRegion.lines` unsigned long type
https://bugs.webkit.org/show_bug.cgi?id=261326

Reviewed by Eric Carlson.

The type of VTTRegion.lines is changed to unsigned long in https://github.com/w3c/webvtt/issues/414,
and VTTRegion.lines no longer throws IndexSizeError
when negative value was set due to the change.

* LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/lines-expected.txt:
* LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt:
* LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html:
* Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::setLines):
(WebCore::VTTRegion::parseSettingValue):
* Source/WebCore/html/track/VTTRegion.h:
* Source/WebCore/html/track/VTTRegion.idl:
* Source/WebCore/html/track/VTTScanner.cpp:
(WebCore::VTTScanner::scanDigits):
* Source/WebCore/html/track/VTTScanner.h:
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectTimeStamp):

Canonical link: https://commits.webkit.org/267827@main




More information about the webkit-changes mailing list