[webkit-changes] [WebKit/WebKit] ff4be9: [motion-path] Implement offset-position support fo...

[Nikos Mouchtaris]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff4be937a37273cf6ca0a491f28a902406dd78f4
      https://github.com/WebKit/WebKit/commit/ff4be937a37273cf6ca0a491f28a902406dd78f4
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/css/BasicShapeFunctions.cpp
    M Source/WebCore/rendering/MotionPath.cpp
    M Source/WebCore/rendering/MotionPath.h
    M Source/WebCore/rendering/PathOperation.h
    M Source/WebCore/rendering/shapes/Shape.cpp
    M Source/WebCore/rendering/style/BasicShapes.cpp
    M Source/WebCore/rendering/style/BasicShapes.h

  Log Message:
  -----------
  [motion-path] Implement offset-position support for circle() / ellipse()
https://bugs.webkit.org/show_bug.cgi?id=261178
rdar://114951375

Reviewed by Simon Fraser.

When the position is not specified for circle or ellipse, use offset-position
instead. Also update normalPositionForOffsetPath to have offset-position: normal
default to the center of the containing block rect for shape path operations.

* LayoutTests/TestExpectations:
* Source/WebCore/css/BasicShapeFunctions.cpp:
(WebCore::basicShapeForValue):
* Source/WebCore/rendering/MotionPath.cpp:
(WebCore::MotionPath::computePathForShape):
* Source/WebCore/rendering/MotionPath.h:
* Source/WebCore/rendering/PathOperation.h:
* Source/WebCore/rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
* Source/WebCore/rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeCircle::floatValueForRadiusInBox const):
(WebCore::BasicShapeCircle::pathForCenterCoordinate const):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::pathForCenterCoordinate const):
(WebCore::BasicShapeEllipse::path):
* Source/WebCore/rendering/style/BasicShapes.h:
(WebCore::BasicShapeHasCenterCoordinate::setPositionWasOmitted):
(WebCore::BasicShapeHasCenterCoordinate::positionWasOmitted const):

Canonical link: https://commits.webkit.org/267810@main