[webkit-changes] [WebKit/WebKit] fae812: [Xcode] "Check .xcfilelists" script phases don't n...

Elliott Williams noreply at github.com
Fri Sep 8 12:25:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fae8124ad3b9591c78b47c08931d4e794b5f0a14
      https://github.com/WebKit/WebKit/commit/fae8124ad3b9591c78b47c08931d4e794b5f0a14
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-09-08 (Fri, 08 Sep 2023)

  Changed paths:
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [Xcode] "Check .xcfilelists" script phases don't need to run on every build
https://bugs.webkit.org/show_bug.cgi?id=261281
rdar://115123881

Reviewed by Alexey Proskuryakov.

Make each "Check .xcfilelists" build phase depend on its
DerivedSources.make file, and output a timestamp file. This allows
XCBuild to incrementalize it properly and avoid re-running it on every
build. It also works towards preventing WebKit's module verifier from
re-running every build and being scheduled late in the target build.

Each xcfilelist generator parses its respective Makefile to determine
its input and output paths, so it's fair to expect the Makefile to
always change when there are new inputs/outputs. Technically this is not
true--Make is free to declare targets nondeterministically--but in
practice, commits which changes xcfilelists also change
DerivedSources.make.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/267805@main




More information about the webkit-changes mailing list